Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced FarmingLib.reduceFarming with stopFarming #68

Conversation

byshape
Copy link
Contributor

@byshape byshape commented Sep 19, 2023

The ability to specify amount of tokens that the distributor wants to rescue from the contract has been removed. Instead, all tokens available for withdrawal are sent to the distributor. As a result, if a reward token withdrawal is requested, the farm is not shortened in duration, but rather ended. View functions have also been added to get the number of tokens available for withdrawal at the current moment or at a specified timestamp.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head c592734 differs from pull request most recent head 41c45b0. Consider uploading reports for the commit 41c45b0 to get more accurate results

📢 Thoughts on this report? Let us know!.

@byshape byshape marked this pull request as ready for review September 20, 2023 13:43
@ZumZoom
Copy link
Member

ZumZoom commented Sep 26, 2023

Closing in favor of #69

@ZumZoom ZumZoom closed this Sep 26, 2023
@ZumZoom ZumZoom deleted the feature/SC-924-proper-rescue-funds-in-farming-contracts branch September 26, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants