Skip to content

Commit

Permalink
feat(fusion-order): do not allow private orders (#72)
Browse files Browse the repository at this point in the history
  • Loading branch information
vbrvk authored Mar 21, 2024
1 parent 3739833 commit 9b8dcdc
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"dependencies": {
"@1inch/byte-utils": "2.2.0",
"@1inch/limit-order-sdk": "4.5.0",
"@1inch/limit-order-sdk": "4.6.1",
"@metamask/eth-sig-util": "^5.0.2",
"bn.js": "^5.2.1",
"ethers": "6.11.0",
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/fusion-order/fusion-order.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,8 @@ export class FusionOrder {

const makerTraits = new MakerTraits(BigInt(order.makerTraits))

assert(!makerTraits.isPrivate(), 'fusion order can not be private')

const auctionDetails = AuctionDetails.fromExtension(extension)

const postInteractionData =
Expand Down

0 comments on commit 9b8dcdc

Please sign in to comment.