Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-1205][SC-1206] Update uniswap v2 and v3 tests to use universal router #15

Merged
merged 30 commits into from
Sep 6, 2024
Merged

[SC-1205][SC-1206] Update uniswap v2 and v3 tests to use universal router #15

merged 30 commits into from
Sep 6, 2024

Conversation

belactriple9
Copy link
Collaborator

Update uniswap v2 and v3 tests to use universal router

zZoMROT
zZoMROT reviewed Aug 3, 2024
View reviewed changes
test/RouterUniV2.js Outdated Show resolved Hide resolved
@zZoMROT
Copy link
Contributor

zZoMROT commented Aug 3, 2024 •
edited
Loading

It seems that the UniversalRouter is less efficient than separate UniV2 or UniV3 routers, but some other protocols are even cheaper than using just the UniV2 or UniV3 routers which are intended specifically for these pools.
Perhaps it would be better to preserve the individual router costs and add the UniversalRouter prices as an additional column in the tables instead of replacing the existing values.
What do you think about it?

zZoMROT
zZoMROT reviewed Aug 3, 2024
View reviewed changes
test/helpers/fixtures.js Outdated Show resolved Hide resolved
zZoMROT
zZoMROT reviewed Aug 3, 2024
View reviewed changes
test/helpers/fixtures.js Outdated Show resolved Hide resolved
zZoMROT
zZoMROT reviewed Aug 3, 2024
View reviewed changes
test/RouterUniV3.js Outdated Show resolved Hide resolved
@zZoMROT zZoMROT changed the title Update uniswap v2 and v3 tests to use universal router [SC-1205] Update uniswap v2 and v3 tests to use universal router Aug 7, 2024
@belactriple9
Copy link
Collaborator Author

I'm unsure the best naming for the uniswap universal router and the old uniswap v2 and uniswap v3 routers since the names are long and eventually may cause some awkward wrapping.

belactriple9 and others added 2 commits August 12, 2024 11:36
@belactriple9
add back uniswap key to fix broken tests
703fbc3
@zZoMROT
Merge branch 'master' into feature/SC-1205
8212360 
# Conflicts:
#	README.md
#	hardhat.config.js
#	test/RouterUniV2V3.js
@ZumZoom ZumZoom merged commit 1995364 into master Sep 6, 2024
1 of 3 checks passed
@ZumZoom ZumZoom deleted the feature/SC-1205 branch September 6, 2024 15:51
@ZumZoom ZumZoom changed the title [SC-1205] Update uniswap v2 and v3 tests to use universal router [SC-1205][SC-1206] Update uniswap v2 and v3 tests to use universal router Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zZoMROT zZoMROT zZoMROT approved these changes

@ZumZoom ZumZoom ZumZoom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belactriple9 @zZoMROT @ZumZoom