Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode zeroBytes #36

Merged
merged 6 commits into from
Feb 24, 2024
Merged

Add mode zeroBytes #36

merged 6 commits into from
Feb 24, 2024

Conversation

0xSynon
Copy link

@0xSynon 0xSynon commented Feb 19, 2024

Adding a mode that scores the results based on the number of zero-bytes. This is similar to the mode "zeros" but for people who want a vanity address with zeros for cheaper calldata gas, this mode should be chosen over "zeros".\

More details #35

profanity.cl Outdated Show resolved Hide resolved
profanity.cpp Outdated Show resolved Hide resolved
@k06a
Copy link
Member

k06a commented Feb 19, 2024

@0xSynon thank you! Please update README.md to include new parameter description

@0xSynon
Copy link
Author

0xSynon commented Feb 19, 2024

@k06a Thank you for the review, I've added a description for the option in the README and in help.hpp. Feel free to rephrase it or change its position

README.md Outdated Show resolved Hide resolved
help.hpp Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
help.hpp Outdated Show resolved Hide resolved
@k06a k06a requested a review from ZumZoom February 20, 2024 22:49
Copy link
Member

@k06a k06a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSynon
Copy link
Author

0xSynon commented Feb 24, 2024

Thanks for the reviews and approvals @ZumZoom @k06a

Just in case you were expecting me to merge it myself once it was approved: I can't

Screenshot 2024-02-24 at 21 59 43

@k06a k06a merged commit bb80947 into 1inch:master Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants