forked from johguse/profanity
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode zeroBytes #36
Merged
Merged
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k06a
reviewed
Feb 19, 2024
k06a
reviewed
Feb 19, 2024
@0xSynon thank you! Please update README.md to include new parameter description |
@k06a Thank you for the review, I've added a description for the option in the README and in |
k06a
reviewed
Feb 20, 2024
k06a
reviewed
Feb 20, 2024
k06a
reviewed
Feb 20, 2024
k06a
reviewed
Feb 20, 2024
k06a
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ZumZoom
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a mode that scores the results based on the number of zero-bytes. This is similar to the mode "zeros" but for people who want a vanity address with zeros for cheaper calldata gas, this mode should be chosen over "zeros".\
More details #35