[SC-583] Optimize AddressArray and AddressSet libs #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 97.36% 93.15% -4.21%
==========================================
Files 16 16
Lines 341 336 -5
Branches 71 66 -5
==========================================
- Hits 332 313 -19
- Misses 9 23 +14 ☔ View full report in Codecov by Sentry. |
ZumZoom
changed the title
# Conflicts: # test/contracts/AddressArray.test.ts
=>
|
|
@zZoMROT pop() didn't receive 5k gas refund, but optimizes future push() by 15k. |
=> |
ZumZoom
previously approved these changes
Mar 21, 2024
|
Multi push/pop tests that show how dirty storage affects add/push: => tldr: |
ZumZoom
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=>