Support for async-aws/flysystem-s3 1.0 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the ping. The conflict section in the composer.json will make this PR backwards compatible. Well done |
Nyholm
approved these changes
Dec 21, 2020
bytehead
approved these changes
Dec 22, 2020
|
Thank you for merging |
|
Note that for Flysystem v2 there is official support: https://packagist.org/packages/league/flysystem-async-aws-s3 |
|
I've already started a branch for 4.x to support Flysystem v2 :) |
|
@derrabus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bumping to 1.0, the Async AWS folks decided to rename their adapter class. This PR makes the necessary adjustments.
I don't know how the BC policies of this project are. Should I build some kind of compatibility layer to support both, 0.4 and 1.0 of that library at the same time? Or is this change acceptable as it is?