Review #4
Open
Review #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1whatleytay
commented
Sep 23, 2019
There was a problem hiding this comment.
Review from @pent0.
Notes: Const where possible. C++ compiler certainly can optimize things better.
| } | ||
| } | ||
|
|
||
| std::string getVaryingName(ProgramVarying varying) { |
There was a problem hiding this comment.
std::string getVaryingName(ProgramVarying varying) {
const char *will be better. You are constructing heap memory... What if you want to useconst char *but not string somewhere in future.- Try to stick with built-in type whenever you can.
| bool isStruct(); | ||
| }; | ||
|
|
||
| class CompilerGXP : public Compiler { |
There was a problem hiding this comment.
- The design is in a way unfriendly with future optimization like another layer of IR.
- Another layer of IR maybe needed because the USSE ops have many opcodes that can optimize SPIRV to the very end.
There was a problem hiding this comment.
I agree. I'm not really aware of any other methods though. I started reading the dragon book a few days ago, it might have a better idea?
There was a problem hiding this comment.
I don't even have it, so idk... Go with your instics.. Personally I try and error and figure out what is better, than copy code from somewhere and make it better... Though this optimization is hard to do. We can keep this note for now.
|
Updated to latest :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.