-
Notifications
You must be signed in to change notification settings - Fork 3
Various Improvements #6
base: master
Are you sure you want to change the base?
Conversation
I also realize that I might have messed up the gitignore with the resx and designer files, not totally sure. This is my first time with winforms, so any advise on how to do this right would be appreciated |
Thanks for submitting a Pull Request! I just want to go over a few things you stated in your initial post.
This popup is just a message that's controlled through pastebin, it's just a way to send a message to everyone when they run it. It can be changed or turned off through the paste at any time. (I guess you could already consider this done since I changed the message today)
Never encountered this issue, I'm only hearing about this now. All the code does is get your Oculus Game's Location from the Registry Keys, then if it finds the target directory (Beat Saber) it'll select that, otherwise just prompt a MessageBox.
I plan, for the day I finally update this program again, to split the uninstall screen, like you said you did (which will make doing this easier), so it's more clear what is happening when you install and uninstall. For adding all versions of BS-Multi to install would be helpful for users who are on older versions of Beat Saber, but I don't know how to grab raw files from GitHub, without it returning 404 errors in the program. (Works fine in browser, but returns 404 Error in Program) I could upload all the older versions to a webserver, then have a JSON file that contains the URLs, and gets them from there.
When installing, it'll replace all files, so if you do have old files, it'll update them to what the 301 Redirect is set to.
For them to add it to the BeatMods website (where most of the verified mods are pulled from), they have to verify the mod first, basically just look through all the code and make sure it's not malicious. There's a LOT of code to look through, which takes a LOT of time, so they probably won't look through it unless a LOT of people want them to. Anyways, I'll read the code whenever I get the time to look into it, and I'll comment again about any changes I make to this code, or if I implement them. Thanks for contributing! |
I love what you are doing here, and really want to help improve it! So far, I have redesigned page 1 to be a little better, but the biggest change I made was to page 2, which has now been split into install and uninstall pages so that there is a lot more space for text describing the options. I also genereally cleaned up the UI, so now there shouldn't be anything overlapping or extending past the edge of the screen.
Feel free to merge this in now, however I do plan on making more changes soon, including:
Anyway, I love that this project helps more people play bsmulti, which is one of my favorite things to do in VR! I might try to talk to the mod assistant people to see if they can integrate this or somehow link to it so it can get more attention, but either way, keep up the good work!