Skip to content
This repository has been archived by the owner on Dec 6, 2020. It is now read-only.

Various Improvements #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Cobular
Copy link

@Cobular Cobular commented Aug 31, 2020

I love what you are doing here, and really want to help improve it! So far, I have redesigned page 1 to be a little better, but the biggest change I made was to page 2, which has now been split into install and uninstall pages so that there is a lot more space for text describing the options. I also genereally cleaned up the UI, so now there shouldn't be anything overlapping or extending past the edge of the screen.

Feel free to merge this in now, however I do plan on making more changes soon, including:

  • removing or rewording the popup about DOVR (not sure what that even is lol)
  • Improving general formatting even more (current formatting is still a bit meh, since I only spent like 30 min on it)
  • Improve error handling for when oculus is installed but beatsaber isn't (just crashes for me)
  • Poke around and see if there are any more weird crashes
  • Add all versions of BS Multi that are detected to the uninstaller options and start them checked, so it is more clear what will occur
  • Add update mode if need for update is detected (may already exist, haven't looked yet)

Anyway, I love that this project helps more people play bsmulti, which is one of my favorite things to do in VR! I might try to talk to the mod assistant people to see if they can integrate this or somehow link to it so it can get more attention, but either way, keep up the good work!

@Cobular
Copy link
Author

Cobular commented Aug 31, 2020

I also realize that I might have messed up the gitignore with the resx and designer files, not totally sure. This is my first time with winforms, so any advise on how to do this right would be appreciated

@200Tigersbloxed
Copy link
Owner

Thanks for submitting a Pull Request! I just want to go over a few things you stated in your initial post.

removing or rewording the popup about DOVR (not sure what that even is lol)

This popup is just a message that's controlled through pastebin, it's just a way to send a message to everyone when they run it. It can be changed or turned off through the paste at any time. (I guess you could already consider this done since I changed the message today)

Improve error handling for when oculus is installed but beatsaber isn't (just crashes for me)

Never encountered this issue, I'm only hearing about this now. All the code does is get your Oculus Game's Location from the Registry Keys, then if it finds the target directory (Beat Saber) it'll select that, otherwise just prompt a MessageBox.

Add all versions of BS Multi that are detected to the uninstaller options and start them checked, so it is more clear what will occur

I plan, for the day I finally update this program again, to split the uninstall screen, like you said you did (which will make doing this easier), so it's more clear what is happening when you install and uninstall. For adding all versions of BS-Multi to install would be helpful for users who are on older versions of Beat Saber, but I don't know how to grab raw files from GitHub, without it returning 404 errors in the program. (Works fine in browser, but returns 404 Error in Program) I could upload all the older versions to a webserver, then have a JSON file that contains the URLs, and gets them from there.

Add update mode if need for update is detected (may already exist, haven't looked yet)

When installing, it'll replace all files, so if you do have old files, it'll update them to what the 301 Redirect is set to.

I might try to talk to the mod assistant people to see if they can integrate this or somehow link to it so it can get more attention

For them to add it to the BeatMods website (where most of the verified mods are pulled from), they have to verify the mod first, basically just look through all the code and make sure it's not malicious. There's a LOT of code to look through, which takes a LOT of time, so they probably won't look through it unless a LOT of people want them to.

Anyways, I'll read the code whenever I get the time to look into it, and I'll comment again about any changes I make to this code, or if I implement them. Thanks for contributing!

@Cobular
Copy link
Author

Cobular commented Sep 2, 2020

No problem! I really want to get more people into multiplayer, and this seems like a great way to make that easier. Also, should have attached these before, but here's some screenshots of the UI changes:
image
image
(only uninstall will go blue if it finds something installed, and vise versa for nothing installed, but I'm not sure if this is actually good or not. Both buttons still work.
image
Install screen adds a lot more text about the versions, so users hopefully won't have to link out elsewhere. I'm pretty sure I got the descriptions right, totally change them if not.
image
Uninstall screen basically just adds info about shared and unshared dependencies, so users can know a bit more about what they are uninstalling.
I think this stuff looks OK, but some positioning stuff is sorta iffy, and I really didn't mess with color that much.
Also, when you are on install/uninstall and press the close button, it doesn't close the program. Instead, it shows that pastebin notification, and goes back to the main screen. I thing a back button is a good idea to have, but it would probably be best to separate those functions. Might be able to format that so it's more clear that it's like a message of the day from the dev so it's purpose is more clear, but I'd never thought to use something like pastebin to create dynamically changeable text, that's such a great idea! I think I'll try to debug the close/back button thing so it properly closes, but I guess we'll see if I end up having time too lol. If I do, the commits should show up here so it doesn't get done twice by accident.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants