Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Epayslips #7714

Closed
wants to merge 16 commits into from
Closed

Add Epayslips #7714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d1b8988
testingfile
spellbind0127 Aug 16, 2023
9b959e6
updates not finished will do later
spellbind0127 Aug 16, 2023
34543a2
updated
spellbind0127 Aug 17, 2023
83b0f6c
Merge branch 'master' into ePayslips
spellbind0127 Aug 17, 2023
489f253
Update epayslips.co.uk.json
spellbind0127 Aug 17, 2023
a32f9c0
Delete testingfile.txt
spellbind0127 Aug 17, 2023
cf8b8a6
Merge branch 'master' into ePayslips
spellbind0127 Aug 18, 2023
7f421ce
fixing invalid json that I just noticed
spellbind0127 Aug 18, 2023
dee33e0
added image should be readdy to be merged
spellbind0127 Aug 18, 2023
8826608
removed contracts to comply with the standered
spellbind0127 Aug 18, 2023
55553bb
json should work this time
spellbind0127 Aug 18, 2023
1f499ce
now will it work finally
spellbind0127 Aug 18, 2023
6a795ab
should be fixed
spellbind0127 Aug 18, 2023
a110a33
Clean up JSON
Carlgo11 Aug 18, 2023
8cf06fe
added the region good catch
spellbind0127 Aug 18, 2023
7762d57
Update entries/e/epayslips.co.uk.json
spellbind0127 Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions entries/e/epayslips.co.uk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"Epayslips": {
"domain": "epayslips.co.uk",
"tfa": [
"u2f",
"custom-software"
],
"categories": [
"finance"
],
"custom-software": [
"Authy",
"Duo"
Comment on lines +12 to +13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their security page mentions Google Authenticator and Duo but nothing about Authy. It also sounds more like they support TOTP (RFC-6238) rather than the proprietary Duo and Authy authentication systems.
Screenshot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going off of the issue that is linked to this pull request but the documentation is probably better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the custom-software element then and replace custom-software inside tfa with totp.

],
"regions": [
"gb"
]
}
}
1 change: 1 addition & 0 deletions img/e/epayslips.co.uk.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading