Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades everything #636

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

jljouannic
Copy link

What else to say? The PR title is explicit enough I think 😄

@jljouannic
Copy link
Author

jljouannic commented Jan 10, 2023

Hi @2fd, would you mind taking a quick look at this PR so that installing @2fd/ant-design-icons alongside with antd 5 stops complaining about unmet peer dependencies antd@^4.0.0

templates/types.mustache Outdated Show resolved Hide resolved
@jljouannic jljouannic requested a review from 2fd January 13, 2023 09:22
@jljouannic
Copy link
Author

Hi @2fd! Did you find some time to check the fix I pushed following the change you requested?

@jljouannic
Copy link
Author

jljouannic commented Apr 7, 2023

Hi @2fd, it's been two month since you requested me to make some changes and me complying to this request. Would you mind taking a look before, hopefully, merge this PR and make a new release of this package? 🙏 🥺

@jljouannic jljouannic force-pushed the upgrade-everything branch from ae925ac to 1d62954 Compare June 5, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants