This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
[BUGFIX] Handle errors when retrieving geometry data - master_2 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a try/except to avoid the plugin to fail creating the fts data.
mdouchin
changed the title
|
@3nids could you please review this PR and accept it if ok for you ? I have needed this try for many different datasets, and this would be great to release a new plugin bug fix version only for this. |
|
when does this error arise? would be better to have this fixed than going through try/except. Sorry for the delay. |
|
I need to find a public dataset to reproduce this error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a try/except to avoid the plugin to fail creating the fts data.