Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREESCALE-10387 add 4.14 as maxOpenShiftVersion to threescale 2.14 #893

Merged

Conversation

carlkyrillos
Copy link
Contributor

JIRA: THREESCALE-10387

Adding 4.14 as maxOpenShiftVersion to 3scale-operator 2.14 stable.

@carlkyrillos carlkyrillos requested a review from a team as a code owner November 15, 2023 14:19
@carlkyrillos
Copy link
Contributor Author

/retest

1 similar comment
@MStokluska
Copy link
Contributor

/retest

@MStokluska
Copy link
Contributor

/test test-e2e

Copy link

openshift-ci bot commented Nov 15, 2023

@MStokluska: No presubmit jobs available for 3scale/[email protected]

In response to this:

/test test-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eguzki
Copy link
Member

eguzki commented Nov 15, 2023

Just heads up that this is missing the label com.redhat.openshift.versions: v4.11-v4.14. Tried here without luck #877

With this, we still would need to add that label in midstream. The annotation would already be covered.

@MStokluska
Copy link
Contributor

Just heads up that this is missing the label com.redhat.openshift.versions: v4.11-v4.14. Tried here without luck #877

With this, we still would need to add that label in midstream. The annotation would already be covered.

Thanks Eguzki, yes, that flag is already in midstream.

@eguzki
Copy link
Member

eguzki commented Nov 15, 2023

Just heads up that this is missing the label com.redhat.openshift.versions: v4.11-v4.14. Tried here without luck #877
With this, we still would need to add that label in midstream. The annotation would already be covered.

Thanks Eguzki, yes, that flag is already in midstream.

I know :) My point was we cannot remove that label from midstream, yet.

@MStokluska
Copy link
Contributor

/lgtm

@carlkyrillos carlkyrillos merged commit 88dfe1a into 3scale:3scale-2.14-stable Nov 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants