Skip to content

Commit

Permalink
improved test coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
@saschaszott
saschaszott authored Dec 13, 2023
1 parent 3b936b5 commit 636046b
Showing 1 changed file with 73 additions and 25 deletions.
98 changes: 73 additions & 25 deletions ...i/src/test/java/org/dspace/metrics/embeddable/impl/EmbeddablePlumXMetricProviderTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.when;

import org.dspace.content.Item;
Expand All @@ -19,6 +18,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;

Expand All @@ -31,7 +31,7 @@
public class EmbeddablePlumXMetricProviderTest {
@Mock
private ItemService itemService;
@Mock
@InjectMocks
private EmbeddablePlumXMetricProvider provider;
@Mock
Context context;
Expand All @@ -40,22 +40,15 @@ public class EmbeddablePlumXMetricProviderTest {

@Before
public void setUp() throws Exception {
when(provider.innerHtml(any(), any())).thenCallRealMethod();
when(provider.getEntityType(any())).thenCallRealMethod();
when(provider.hasMetric(any(), any(), any())).thenCallRealMethod();
when(provider.getItemService()).thenReturn(itemService);

provider.personPlumXScript = "//cdn.plu.mx/widget-person.js";
provider.publicationPlumXScript = "//cdn.plu.mx/widget-popup.js";
provider.publicationHref = "https://plu.mx/plum/a/";
provider.personHref = "https://plu.mx/plum/u/";
provider.dataNumArtifacts = 5;
provider.dataWidth = "350px";
provider.dataPopup = "left";
provider.listDataWidth = "350px";
provider.listDataPopup = "left";
provider.setPersonListViewEnabled(true);
provider.setPublicationListViewEnabled(true);
provider.setPersonPlumXScript("//cdn.plu.mx/widget-person.js");
provider.setPublicationPlumXScript("//cdn.plu.mx/widget-popup.js");
provider.setPublicationHref("https://plu.mx/plum/a/");
provider.setPersonHref("https://plu.mx/plum/u/");
provider.setDataNumArtifacts(5);
provider.setDataWidth("350px");
provider.setDataPopup("left");
provider.setListDataWidth("350px");
provider.setListDataPopup("left");
}

@Test
Expand All @@ -66,14 +59,16 @@ public void hasMetricEmptyEntityType() {

@Test
public void hasMetricPublicationWithoutDoi() {
provider.setPublicationListViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace", "entity", "type", Item.ANY)).thenReturn("Publication");
when(itemService.getMetadataFirstValue(item, "dc", "identifier", "doi", Item.ANY)).thenReturn(null);
boolean hasMetric = provider.hasMetric(context, item, null);
assertFalse(hasMetric);
}

@Test
public void hasMetricPublicationWithDoi() {
public void hasMetricPublicationWithDoiEnabled() {
provider.setPublicationListViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace",
"entity", "type", Item.ANY)).thenReturn("Publication");
when(itemService.getMetadataFirstValue(item, "dc",
Expand All @@ -83,7 +78,19 @@ public void hasMetricPublicationWithDoi() {
}

@Test
public void hasMetricPublicationWithOrcid() {
public void hasMetricPublicationWithDoiDisabled() {
provider.setPersonListViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace",
"entity", "type", Item.ANY)).thenReturn("Publication");
when(itemService.getMetadataFirstValue(item, "dc",
"identifier", "doi", Item.ANY)).thenReturn("10.1016/j.gene.2009.04.019");
boolean hasMetric = provider.hasMetric(context, item, null);
assertFalse(hasMetric);
}

@Test
public void hasMetricPersonWithOrcidEnabled() {
provider.setPersonListViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace",
"entity", "type", Item.ANY)).thenReturn("Person");
when(itemService.getMetadataFirstValue(item, "person",
Expand All @@ -93,7 +100,19 @@ public void hasMetricPublicationWithOrcid() {
}

@Test
public void hasMetricPublicationWithoutOrcid() {
public void hasMetricPersonWithOrcidDisabled() {
provider.setPublicationListViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace",
"entity", "type", Item.ANY)).thenReturn("Person");
when(itemService.getMetadataFirstValue(item, "person",
"identifier", "orcid", Item.ANY)).thenReturn("0000-0002-9029-1854");
boolean hasMetric = provider.hasMetric(context, item, null);
assertFalse(hasMetric);
}

@Test
public void hasMetricPersonWithoutOrcid() {
provider.setPersonListViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace", "entity", "type", Item.ANY)).thenReturn("Person");
when(itemService.getMetadataFirstValue(item, "person", "identifier", "orcid", Item.ANY)).thenReturn(null);
boolean hasMetric = provider.hasMetric(context, item, null);
Expand All @@ -102,13 +121,15 @@ public void hasMetricPublicationWithoutOrcid() {

@Test
public void innerHtmlForPersonItem() {
provider.setPersonListViewEnabled(true);
provider.setPersonDetailViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace", "entity", "type", Item.ANY)).thenReturn("Person");
when(itemService.getMetadataFirstValue(item, "person", "identifier", "orcid", Item.ANY))
.thenReturn("0000-0002-9029-1854");
String template = provider.innerHtml(context, item);

assertEquals("{\"data-person-badge-enabled\":false,\"list-data-person-badge-enabled\":true," +
"\"data-publication-badge-enabled\":false,\"list-data-publication-badge-enabled\":true," +
assertEquals("{\"data-person-badge-enabled\":true,\"list-data-person-badge-enabled\":true," +
"\"data-publication-badge-enabled\":false,\"list-data-publication-badge-enabled\":false," +
"\"type\":\"Person\",\"list-type\":\"Person\",\"placeholder\":\"\",\"list-placeholder\":\"\"," +
"\"src\":\"//cdn.plu.mx/widget-person.js\",\"href\":\"https://plu.mx/plum/u/?orcid=0000-0002-9029-1854\"," +
"\"list-src\":\"//cdn.plu.mx/widget-person.js\"," +
Expand All @@ -128,13 +149,15 @@ public void innerHtmlForPersonItem() {

@Test
public void innerHtmlForPublicationItem() {
provider.setPublicationListViewEnabled(true);
provider.setPublicationDetailViewEnabled(true);
when(itemService.getMetadataFirstValue(item, "dspace", "entity", "type", Item.ANY)).thenReturn("Publication");
when(itemService.getMetadataFirstValue(item, "dc", "identifier", "doi", Item.ANY))
.thenReturn("10.1016/j.gene.2009.04.019");
String template = provider.innerHtml(context, item);

assertEquals("{\"data-person-badge-enabled\":false,\"list-data-person-badge-enabled\":true," +
"\"data-publication-badge-enabled\":false,\"list-data-publication-badge-enabled\":true," +
assertEquals("{\"data-person-badge-enabled\":false,\"list-data-person-badge-enabled\":false," +
"\"data-publication-badge-enabled\":true,\"list-data-publication-badge-enabled\":true," +
"\"type\":\"Publication\",\"list-type\":\"Publication\",\"placeholder\":\"\"," +
"\"list-placeholder\":\"\",\"src\":\"//cdn.plu.mx/widget-popup.js\"," +
"\"href\":\"https://plu.mx/plum/a/?doi=10.1016/j.gene.2009.04.019\"," +
Expand All @@ -152,4 +175,29 @@ public void innerHtmlForPublicationItem() {
"\"list-data-hide-socialmedia\":false,\"list-data-hide-citations\":false," +
"\"list-data-pass-hidden-categories\":false,\"list-data-detail-same-page\":false}", template);
}

@Test
public void innerHtmlForOtherItem() {
when(itemService.getMetadataFirstValue(item, "dspace", "entity", "type", Item.ANY)).thenReturn("Other");
String template = provider.innerHtml(context, item);

assertEquals("{\"data-person-badge-enabled\":false,\"list-data-person-badge-enabled\":false," +
"\"data-publication-badge-enabled\":false,\"list-data-publication-badge-enabled\":false," +
"\"type\":\"Other\",\"list-type\":\"Other\",\"placeholder\":\"\",\"list-placeholder\":\"\"," +
"\"src\":\"//cdn.plu.mx/widget-popup.js\",\"href\":\"https://plu.mx/plum/a/?doi=null\"," +
"\"list-src\":\"//cdn.plu.mx/widget-popup.js\"," +
"\"list-href\":\"https://plu.mx/plum/a/?doi=null\",\"data-no-name\":false," +
"\"data-num-artifacts\":5,\"data-width\":\"350px\",\"data-no-description\":false," +
"\"data-no-stats\":false,\"data-no-thumbnail\":false,\"data-no-artifacts\":false," +
"\"data-popup\":\"left\",\"data-hide-when-empty\":false,\"data-hide-usage\":false," +
"\"data-hide-captures\":false,\"data-hide-mentions\":false,\"data-hide-socialmedia\":false," +
"\"data-hide-citations\":false,\"data-pass-hidden-categories\":false,\"data-detail-same-page\":false," +
"\"list-data-no-name\":false,\"list-data-num-artifacts\":0,\"list-data-width\":\"350px\"," +
"\"list-data-no-description\":false,\"list-data-no-stats\":false,\"list-data-no-thumbnail\":false," +
"\"list-data-no-artifacts\":false,\"list-data-popup\":\"left\",\"list-data-hide-when-empty\":false," +
"\"list-data-hide-usage\":false,\"list-data-hide-captures\":false,\"list-data-hide-mentions\":false," +
"\"list-data-hide-socialmedia\":false,\"list-data-hide-citations\":false," +
"\"list-data-pass-hidden-categories\":false,\"list-data-detail-same-page\":false}", template);
}

}

0 comments on commit 636046b

Please sign in to comment.