Add some logging at the debug level

4Science · Mar 27, 2024 · e7e2373 · e7e2373
1 parent 727080e
commit e7e2373
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/...e-api/src/main/java/org/dspace/content/enhancer/service/impl/ItemEnhancerServiceImpl.java b/...e-api/src/main/java/org/dspace/content/enhancer/service/impl/ItemEnhancerServiceImpl.java
@@ -11,6 +11,7 @@
 import java.util.List;
 import java.util.UUID;
 
+import org.apache.logging.log4j.Logger;
 import org.dspace.authorize.AuthorizeException;
 import org.dspace.content.Item;
 import org.dspace.content.dao.ItemForMetadataEnhancementUpdateDAO;
@@ -28,6 +29,11 @@
  */
 public class ItemEnhancerServiceImpl implements ItemEnhancerService {
 
+    /**
+     * log4j category
+     */
+    private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(ItemEnhancerServiceImpl.class);
+
     @Autowired
     private List<ItemEnhancer> itemEnhancers;
 
@@ -41,14 +47,15 @@ public class ItemEnhancerServiceImpl implements ItemEnhancerService {
     public void enhance(Context context, Item item, boolean deepMode) {
         boolean isUpdateNeeded = false;
         if (deepMode) {
-            itemForMetadataEnhancementUpdateDAO.removeItemForUpdate(context, item.getID());
+            final UUID id = item.getID();
+            log.debug("deepMode enabled, removing item with uuid {} from the queue", id);
+            itemForMetadataEnhancementUpdateDAO.removeItemForUpdate(context, id);
         }
         for (ItemEnhancer itemEnhancer : itemEnhancers) {
             if (itemEnhancer.canEnhance(context, item)) {
                 isUpdateNeeded = itemEnhancer.enhance(context, item, deepMode) || isUpdateNeeded;
             }
         }
-
         if (isUpdateNeeded) {
             updateItem(context, item);
             try {
@@ -61,7 +68,8 @@ public void enhance(Context context, Item item, boolean deepMode) {
 
     @Override
     public void saveAffectedItemsForUpdate(Context context, UUID uuid) throws SQLException {
-        itemForMetadataEnhancementUpdateDAO.saveAffectedItemsForUpdate(context, uuid);
+        int queued = itemForMetadataEnhancementUpdateDAO.saveAffectedItemsForUpdate(context, uuid);
+        log.debug("queued {} items for metadata enhancement check", queued);
     }
 
     @Override

diff --git a/...er-webapp/src/main/java/org/dspace/app/rest/enhancer/RelatedItemEnhancerUpdatePoller.java b/...er-webapp/src/main/java/org/dspace/app/rest/enhancer/RelatedItemEnhancerUpdatePoller.java
@@ -34,14 +34,17 @@ public class RelatedItemEnhancerUpdatePoller {
     @Scheduled(fixedDelayString = "${related-item-enhancer-poller.delay}")
     public void pollItemToUpdateAndProcess() {
         try {
+            log.debug("item enhancer poller executed");
             Context context = new Context();
             context.turnOffAuthorisationSystem();
             UUID extractedUuid;
             while ((extractedUuid = itemEnhancerService.pollItemToUpdate(context)) != null) {
+                log.debug("item enhancer poller processing {}", extractedUuid);
                 Item item = itemService.find(context, extractedUuid);
                 if (item != null) {
                     itemEnhancerService.enhance(context, item, true);
                 }
+                log.debug("item enhancer poller committing");
                 context.commit();
             }
             context.restoreAuthSystemState();