Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
*Fixes #352
Description
Update dependencies to citeproc2.
Instructions for Reviewers
I'm not sure about the new dependencies which are introduced in the new package.
https://mvnrepository.com/artifact/de.undercouch/citeproc-java
which might conflict with existing packages (some were excluded)). And also I'm not sure whether the new dependencies have the correct license.
https://mvnrepository.com/artifact/de.undercouch/citeproc-java
Perhaps it's easier to wait for the upcoming release of citeproc version 3 where all dependencies have licenses that are similiar to the 1.0.1 version.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
pom.xml
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.