Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update citeproc dependency #354

Draft
wants to merge 2 commits into
base: dspace-cris-2023_02_x
Choose a base branch
from

Conversation

floriangantner
Copy link

References

*Fixes #352

Description

Update dependencies to citeproc2.

Instructions for Reviewers

I'm not sure about the new dependencies which are introduced in the new package.

https://mvnrepository.com/artifact/de.undercouch/citeproc-java
which might conflict with existing packages (some were excluded)). And also I'm not sure whether the new dependencies have the correct license.

https://mvnrepository.com/artifact/de.undercouch/citeproc-java
Perhaps it's easier to wait for the upcoming release of citeproc version 3 where all dependencies have licenses that are similiar to the 1.0.1 version.

List of changes in this PR:

  • update dependencies
  • For testing: Application should build and start and generate some csl.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@floriangantner floriangantner changed the base branch from dspace-cris-7 to main-cris February 20, 2024 15:00
[maven-release-plugin] copy for tag dspace-cris-2023.02.02
@floriangantner floriangantner changed the base branch from main-cris to dspace-cris-2023_02_x April 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no csl on jdk17 builds
1 participant