Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset information about modified or added items in subscription context #381

Merged

Conversation

olli-gold
Copy link

@olli-gold olli-gold commented Aug 30, 2023

References

Description

This PR resets information about modified or added items in subscription context. (see #380)

Instructions for Reviewers

See #380 for more information about the bug, which is resolved here.

List of changes in this PR:

  • This PR just adds clearing of the item cache for subscriptions

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@olli-gold olli-gold changed the title fixes #380: reset information about modified or added items in subscr… Reset information about modified or added items in subscription context Aug 30, 2023
@4science-it 4science-it merged commit de0e571 into 4Science:dspace-cris-7 Nov 15, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions of Items are sending mails to non-subscribers
3 participants