refactor, improve code according to suggestions

4Science · Dec 13, 2023 · 922172d · 922172d
1 parent ec82139
commit 922172d
Show file tree

Hide file tree

Showing 51 changed files with 104 additions and 99 deletions.
diff --git a/src/app/admin/admin-notifications/admin-notifications-routing.module.ts b/src/app/admin/admin-notifications/admin-notifications-routing.module.ts
@@ -11,7 +11,7 @@ import { AdminQualityAssuranceTopicsPageResolver } from './admin-quality-assuran
 import { AdminQualityAssuranceEventsPageResolver } from './admin-quality-assurance-events-page/admin-quality-assurance-events-page.resolver';
 import { AdminQualityAssuranceSourcePageComponent } from './admin-quality-assurance-source-page-component/admin-quality-assurance-source-page.component';
 import { AdminQualityAssuranceSourcePageResolver } from './admin-quality-assurance-source-page-component/admin-quality-assurance-source-page-resolver.service';
-import { SourceDataResolver } from './admin-quality-assurance-source-page-component/admin-quality-assurance-source-data.reslover';
+import { SourceDataResolver } from './admin-quality-assurance-source-page-component/admin-quality-assurance-source-data.resolver';
 
 @NgModule({
   imports: [

diff --git a/src/app/admin/admin-notifications/admin-notifications.module.ts b/src/app/admin/admin-notifications/admin-notifications.module.ts
@@ -6,15 +6,15 @@ import { AdminNotificationsRoutingModule } from './admin-notifications-routing.m
 import { AdminQualityAssuranceTopicsPageComponent } from './admin-quality-assurance-topics-page/admin-quality-assurance-topics-page.component';
 import { AdminQualityAssuranceEventsPageComponent } from './admin-quality-assurance-events-page/admin-quality-assurance-events-page.component';
 import { AdminQualityAssuranceSourcePageComponent } from './admin-quality-assurance-source-page-component/admin-quality-assurance-source-page.component';
-import {SuggestionNotificationsModule} from '../../suggestion-notifications/suggestion-notifications.module';
+import {NotificationsModule} from '../../notifications/notifications.module';
 
 @NgModule({
   imports: [
     CommonModule,
     SharedModule,
     CoreModule.forRoot(),
     AdminNotificationsRoutingModule,
-    SuggestionNotificationsModule
+    NotificationsModule
   ],
   declarations: [
     AdminQualityAssuranceTopicsPageComponent,

diff --git a/...quality-assurance-source-data.reslover.ts → ...quality-assurance-source-data.resolver.ts b/...quality-assurance-source-data.reslover.ts → ...quality-assurance-source-data.resolver.ts
@@ -3,8 +3,8 @@ import { ActivatedRouteSnapshot, Resolve, RouterStateSnapshot, Router } from '@a
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
 import { PaginatedList } from '../../../core/data/paginated-list.model';
-import { QualityAssuranceSourceObject } from '../../../core/suggestion-notifications/qa/models/quality-assurance-source.model';
-import { QualityAssuranceSourceService } from '../../../suggestion-notifications/qa/source/quality-assurance-source.service';
+import { QualityAssuranceSourceObject } from '../../../core/notifications/qa/models/quality-assurance-source.model';
+import { QualityAssuranceSourceService } from '../../../notifications/qa/source/quality-assurance-source.service';
 /**
  * This class represents a resolver that retrieve the route data before the route is activated.
  */

diff --git a/src/app/core/core.module.ts b/src/app/core/core.module.ts
@@ -157,9 +157,9 @@ import { SequenceService } from './shared/sequence.service';
 import { CoreState } from './core-state.model';
 import { GroupDataService } from './eperson/group-data.service';
 import { SubmissionAccessesModel } from './config/models/config-submission-accesses.model';
-import { QualityAssuranceTopicObject } from './suggestion-notifications/qa/models/quality-assurance-topic.model';
-import { QualityAssuranceEventObject } from './suggestion-notifications/qa/models/quality-assurance-event.model';
-import { QualityAssuranceSourceObject } from './suggestion-notifications/qa/models/quality-assurance-source.model';
+import { QualityAssuranceTopicObject } from './notifications/qa/models/quality-assurance-topic.model';
+import { QualityAssuranceEventObject } from './notifications/qa/models/quality-assurance-event.model';
+import { QualityAssuranceSourceObject } from './notifications/qa/models/quality-assurance-source.model';
 import { RatingAdvancedWorkflowInfo } from './tasks/models/rating-advanced-workflow-info.model';
 import { AdvancedWorkflowInfo } from './tasks/models/advanced-workflow-info.model';
 import { SelectReviewerAdvancedWorkflowInfo } from './tasks/models/select-reviewer-advanced-workflow-info.model';

diff --git a/...lity-assurance-event-data.service.spec.ts → ...lity-assurance-event-data.service.spec.ts b/...lity-assurance-event-data.service.spec.ts → ...lity-assurance-event-data.service.spec.ts
diff --git a/...s/quality-assurance-event-data.service.ts → ...s/quality-assurance-event-data.service.ts b/...s/quality-assurance-event-data.service.ts → ...s/quality-assurance-event-data.service.ts
diff --git a/...y-assurance-event-object.resource-type.ts → ...y-assurance-event-object.resource-type.ts b/...y-assurance-event-object.resource-type.ts → ...y-assurance-event-object.resource-type.ts
diff --git a/...a/models/quality-assurance-event.model.ts → ...a/models/quality-assurance-event.model.ts b/...a/models/quality-assurance-event.model.ts → ...a/models/quality-assurance-event.model.ts
diff --git a/...-assurance-source-object.resource-type.ts → ...-assurance-source-object.resource-type.ts b/...-assurance-source-object.resource-type.ts → ...-assurance-source-object.resource-type.ts
diff --git a/.../models/quality-assurance-source.model.ts → .../models/quality-assurance-source.model.ts b/.../models/quality-assurance-source.model.ts → .../models/quality-assurance-source.model.ts
diff --git a/...y-assurance-topic-object.resource-type.ts → ...y-assurance-topic-object.resource-type.ts b/...y-assurance-topic-object.resource-type.ts → ...y-assurance-topic-object.resource-type.ts
diff --git a/...a/models/quality-assurance-topic.model.ts → ...a/models/quality-assurance-topic.model.ts b/...a/models/quality-assurance-topic.model.ts → ...a/models/quality-assurance-topic.model.ts
diff --git a/...ity-assurance-source-data.service.spec.ts → ...ity-assurance-source-data.service.spec.ts b/...ity-assurance-source-data.service.spec.ts → ...ity-assurance-source-data.service.spec.ts
diff --git a/.../quality-assurance-source-data.service.ts → .../quality-assurance-source-data.service.ts b/.../quality-assurance-source-data.service.ts → .../quality-assurance-source-data.service.ts
diff --git a/...lity-assurance-topic-data.service.spec.ts → ...lity-assurance-topic-data.service.spec.ts b/...lity-assurance-topic-data.service.spec.ts → ...lity-assurance-topic-data.service.spec.ts
diff --git a/...s/quality-assurance-topic-data.service.ts → ...s/quality-assurance-topic-data.service.ts b/...s/quality-assurance-topic-data.service.ts → ...s/quality-assurance-topic-data.service.ts
diff --git a/...tions/suggestion-notifications-effects.ts → ...pp/notifications/notifications-effects.ts b/...tions/suggestion-notifications-effects.ts → ...pp/notifications/notifications-effects.ts
@@ -1,7 +1,7 @@
 import { QualityAssuranceSourceEffects } from './qa/source/quality-assurance-source.effects';
 import { QualityAssuranceTopicsEffects } from './qa/topics/quality-assurance-topics.effects';
 
-export const suggestionNotificationsEffects = [
+export const notificationsEffects = [
   QualityAssuranceTopicsEffects,
   QualityAssuranceSourceEffects
 ];
diff --git a/...stion-notifications-state.service.spec.ts → ...tions/notifications-state.service.spec.ts b/...stion-notifications-state.service.spec.ts → ...tions/notifications-state.service.spec.ts
@@ -2,8 +2,8 @@ import { TestBed } from '@angular/core/testing';
 import { Store, StoreModule } from '@ngrx/store';
 import { provideMockStore } from '@ngrx/store/testing';
 import { cold } from 'jasmine-marbles';
-import { suggestionNotificationsReducers } from './suggestion-notifications.reducer';
-import { SuggestionNotificationsStateService } from './suggestion-notifications-state.service';
+import { suggestionNotificationsReducers } from './notifications.reducer';
+import { NotificationsStateService } from './notifications-state.service';
 import {
   qualityAssuranceSourceObjectMissingPid,
   qualityAssuranceSourceObjectMoreAbstract,
@@ -16,7 +16,7 @@ import { RetrieveAllTopicsAction } from './qa/topics/quality-assurance-topics.ac
 import { RetrieveAllSourceAction } from './qa/source/quality-assurance-source.actions';
 
 describe('NotificationsStateService', () => {
-  let service: SuggestionNotificationsStateService;
+  let service: NotificationsStateService;
   let serviceAsAny: any;
   let store: any;
   let initialState: any;
@@ -67,14 +67,14 @@ describe('NotificationsStateService', () => {
           ],
           providers: [
             provideMockStore({ initialState }),
-            { provide: SuggestionNotificationsStateService, useValue: service }
+            { provide: NotificationsStateService, useValue: service }
           ]
         }).compileComponents();
       });
 
       beforeEach(() => {
         store = TestBed.get(Store);
-        service = new SuggestionNotificationsStateService(store);
+        service = new NotificationsStateService(store);
         serviceAsAny = service;
         spyOn(store, 'dispatch');
       });
@@ -159,14 +159,14 @@ describe('NotificationsStateService', () => {
           ],
           providers: [
             provideMockStore({ initialState }),
-            { provide: SuggestionNotificationsStateService, useValue: service }
+            { provide: NotificationsStateService, useValue: service }
           ]
         }).compileComponents();
       });
 
       beforeEach(() => {
         store = TestBed.get(Store);
-        service = new SuggestionNotificationsStateService(store);
+        service = new NotificationsStateService(store);
         serviceAsAny = service;
         spyOn(store, 'dispatch');
       });
@@ -255,14 +255,14 @@ describe('NotificationsStateService', () => {
           ],
           providers: [
             provideMockStore({ initialState }),
-            { provide: SuggestionNotificationsStateService, useValue: service }
+            { provide: NotificationsStateService, useValue: service }
           ]
         }).compileComponents();
       });
 
       beforeEach(() => {
         store = TestBed.get(Store);
-        service = new SuggestionNotificationsStateService(store);
+        service = new NotificationsStateService(store);
         serviceAsAny = service;
         spyOn(store, 'dispatch');
       });
@@ -325,14 +325,14 @@ describe('NotificationsStateService', () => {
           ],
           providers: [
             provideMockStore({ initialState }),
-            { provide: SuggestionNotificationsStateService, useValue: service }
+            { provide: NotificationsStateService, useValue: service }
           ]
         }).compileComponents();
       });
 
       beforeEach(() => {
         store = TestBed.get(Store);
-        service = new SuggestionNotificationsStateService(store);
+        service = new NotificationsStateService(store);
         serviceAsAny = service;
         spyOn(store, 'dispatch');
       });
@@ -417,14 +417,14 @@ describe('NotificationsStateService', () => {
           ],
           providers: [
             provideMockStore({ initialState }),
-            { provide: SuggestionNotificationsStateService, useValue: service }
+            { provide: NotificationsStateService, useValue: service }
           ]
         }).compileComponents();
       });
 
       beforeEach(() => {
         store = TestBed.get(Store);
-        service = new SuggestionNotificationsStateService(store);
+        service = new NotificationsStateService(store);
         serviceAsAny = service;
         spyOn(store, 'dispatch');
       });
@@ -513,14 +513,14 @@ describe('NotificationsStateService', () => {
           ],
           providers: [
             provideMockStore({ initialState }),
-            { provide: SuggestionNotificationsStateService, useValue: service }
+            { provide: NotificationsStateService, useValue: service }
           ]
         }).compileComponents();
       });
 
       beforeEach(() => {
         store = TestBed.get(Store);
-        service = new SuggestionNotificationsStateService(store);
+        service = new NotificationsStateService(store);
         serviceAsAny = service;
         spyOn(store, 'dispatch');
       });

diff --git a/...suggestion-notifications-state.service.ts → ...ifications/notifications-state.service.ts b/...suggestion-notifications-state.service.ts → ...ifications/notifications-state.service.ts
@@ -16,17 +16,17 @@ import {
   getQualityAssuranceSourceCurrentPageSelector,
   getQualityAssuranceSourceTotalsSelector
 } from './selectors';
-import { QualityAssuranceTopicObject } from '../core/suggestion-notifications/qa/models/quality-assurance-topic.model';
-import { SuggestionNotificationsState } from './suggestion-notifications.reducer';
+import { QualityAssuranceTopicObject } from '../core/notifications/qa/models/quality-assurance-topic.model';
+import { SuggestionNotificationsState } from './notifications.reducer';
 import { RetrieveAllTopicsAction } from './qa/topics/quality-assurance-topics.actions';
-import { QualityAssuranceSourceObject } from '../core/suggestion-notifications/qa/models/quality-assurance-source.model';
+import { QualityAssuranceSourceObject } from '../core/notifications/qa/models/quality-assurance-source.model';
 import { RetrieveAllSourceAction } from './qa/source/quality-assurance-source.actions';
 
 /**
  * The service handling the Notifications State.
  */
 @Injectable()
-export class SuggestionNotificationsStateService {
+export class NotificationsStateService {
 
   /**
    * Initialize the service variables.

diff --git a/...ations/suggestion-notifications.module.ts → ...app/notifications/notifications.module.ts b/...ations/suggestion-notifications.module.ts → ...app/notifications/notifications.module.ts
@@ -8,32 +8,32 @@ import { SharedModule } from '../shared/shared.module';
 import { storeModuleConfig } from '../app.reducer';
 import { QualityAssuranceTopicsComponent } from './qa/topics/quality-assurance-topics.component';
 import { QualityAssuranceEventsComponent } from './qa/events/quality-assurance-events.component';
-import { SuggestionNotificationsStateService } from './suggestion-notifications-state.service';
-import { suggestionNotificationsReducers, SuggestionNotificationsState } from './suggestion-notifications.reducer';
-import { suggestionNotificationsEffects } from './suggestion-notifications-effects';
+import { NotificationsStateService } from './notifications-state.service';
+import { suggestionNotificationsReducers, SuggestionNotificationsState } from './notifications.reducer';
+import { notificationsEffects } from './notifications-effects';
 import { QualityAssuranceTopicsService } from './qa/topics/quality-assurance-topics.service';
 import {
   QualityAssuranceTopicDataService
-} from '../core/suggestion-notifications/qa/topics/quality-assurance-topic-data.service';
+} from '../core/notifications/qa/topics/quality-assurance-topic-data.service';
 import {
   QualityAssuranceEventDataService
-} from '../core/suggestion-notifications/qa/events/quality-assurance-event-data.service';
+} from '../core/notifications/qa/events/quality-assurance-event-data.service';
 import { ProjectEntryImportModalComponent } from './qa/project-entry-import-modal/project-entry-import-modal.component';
 import { TranslateModule } from '@ngx-translate/core';
 import { SearchModule } from '../shared/search/search.module';
 import { QualityAssuranceSourceComponent } from './qa/source/quality-assurance-source.component';
 import { QualityAssuranceSourceService } from './qa/source/quality-assurance-source.service';
 import {
   QualityAssuranceSourceDataService
-} from '../core/suggestion-notifications/qa/source/quality-assurance-source-data.service';
+} from '../core/notifications/qa/source/quality-assurance-source-data.service';
 
 const MODULES = [
   CommonModule,
   SharedModule,
   SearchModule,
   CoreModule.forRoot(),
   StoreModule.forFeature('suggestionNotifications', suggestionNotificationsReducers, storeModuleConfig as StoreConfig<SuggestionNotificationsState, Action>),
-  EffectsModule.forFeature(suggestionNotificationsEffects),
+  EffectsModule.forFeature(notificationsEffects),
   TranslateModule
 ];
 
@@ -50,7 +50,7 @@ const ENTRY_COMPONENTS = [
 ];
 
 const PROVIDERS = [
-  SuggestionNotificationsStateService,
+  NotificationsStateService,
   QualityAssuranceTopicsService,
   QualityAssuranceSourceService,
   QualityAssuranceTopicDataService,
@@ -82,5 +82,5 @@ const PROVIDERS = [
 /**
  * This module handles all components that are necessary for the OpenAIRE components
  */
-export class SuggestionNotificationsModule {
+export class NotificationsModule {
 }
diff --git a/...tions/suggestion-notifications.reducer.ts → ...pp/notifications/notifications.reducer.ts b/...tions/suggestion-notifications.reducer.ts → ...pp/notifications/notifications.reducer.ts
diff --git a/...s/quality-assurance-events.component.html → ...s/quality-assurance-events.component.html b/...s/quality-assurance-events.component.html → ...s/quality-assurance-events.component.html
@@ -52,13 +52,14 @@ <h4 class="border-bottom pb-2">
                   </td>
                   <td><a *ngIf="eventElement?.target"
                          target="_blank"
+                         rel="noopener noreferrer"
                          [routerLink]="['/items', eventElement?.target?.id]">{{eventElement.title}}</a>
                     <span *ngIf="!eventElement?.target">{{eventElement.title}}</span>
                   </td>
                   <td *ngIf="showTopic.indexOf('/PID') !== -1">
                     <p><span class="small">{{'quality-assurance.event.table.pidtype' | translate}}</span>&nbsp;<span class="badge badge-info">{{eventElement.event.message.type}}</span></p>
                     <p><span class="small">{{'quality-assurance.event.table.pidvalue' | translate}}</span><br>
-                      <a *ngIf="hasPIDHref(eventElement.event.message); else noPID" href="{{getPIDHref(eventElement.event.message)}}" target="_blank">
+                      <a *ngIf="hasPIDHref(eventElement.event.message); else noPID" href="{{getPIDHref(eventElement.event.message)}}" rel="noopener noreferrer" target="_blank">
                         {{eventElement.event.message.value}}
                       </a>
                       <ng-template #noPID><span class="badge badge-info">{{eventElement.event.message.value}}</span></ng-template>
@@ -84,7 +85,7 @@ <h4 class="border-bottom pb-2">
                     </p>
                     <p>
                       <span class="small">{{'quality-assurance.event.table.project' | translate}}</span><br>
-                      <a href="https://explore.openaire.eu/search/project?projectId={{ eventElement.event.message.openaireId}}" target="_blank">{{eventElement.event.message.title}}</a>
+                      <a href="{{openAireUrl}}{{ eventElement.event.message.openaireId}}" rel="noopener noreferrer" target="_blank">{{eventElement.event.message.title}}</a>
                     </p>
                     <p>
                       <span *ngIf="eventElement.event.message.acronym"><span class="small">{{'quality-assurance.event.table.acronym' | translate}}</span>&nbsp;<span class="badge badge-info">{{eventElement.event.message.acronym}}</span><br></span>
@@ -96,7 +97,7 @@ <h4 class="border-bottom pb-2">
                     <hr>
                     <div>
                       {{(eventElement.hasProject ? 'quality-assurance.event.project.found' : 'quality-assurance.event.project.notFound') | translate}}
-                      <a target="_blank" *ngIf="eventElement.hasProject" title="{{eventElement.projectTitle}}" [routerLink]="['/items', eventElement.projectId]">{{eventElement.handle}} </a>
+                      <a target="_blank" rel="noopener noreferrer" *ngIf="eventElement.hasProject" title="{{eventElement.projectTitle}}" [routerLink]="['/items', eventElement.projectId]">{{eventElement.handle}} </a>
                       <div class="btn-group">
                         <button *ngIf="!eventElement.hasProject"
                                 class="btn btn-outline-primary btn-sm"

diff --git a/...s/quality-assurance-events.component.scss → ...s/quality-assurance-events.component.scss b/...s/quality-assurance-events.component.scss → ...s/quality-assurance-events.component.scss
diff --git a/...uality-assurance-events.component.spec.ts → ...uality-assurance-events.component.spec.ts b/...uality-assurance-events.component.spec.ts → ...uality-assurance-events.component.spec.ts
@@ -7,7 +7,7 @@ import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
 import { of as observableOf } from 'rxjs';
 import {
   QualityAssuranceEventDataService
-} from '../../../core/suggestion-notifications/qa/events/quality-assurance-event-data.service';
+} from '../../../core/notifications/qa/events/quality-assurance-event-data.service';
 import { QualityAssuranceEventsComponent } from './quality-assurance-events.component';
 import {
   getMockQualityAssuranceEventRestService,
@@ -26,7 +26,7 @@ import { ActivatedRouteStub } from '../../../shared/testing/active-router.stub';
 import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
 import {
   QualityAssuranceEventObject
-} from '../../../core/suggestion-notifications/qa/models/quality-assurance-event.model';
+} from '../../../core/notifications/qa/models/quality-assurance-event.model';
 import { QualityAssuranceEventData } from '../project-entry-import-modal/project-entry-import-modal.component';
 import { TestScheduler } from 'rxjs/testing';
 import { cold, getTestScheduler } from 'jasmine-marbles';

diff --git a/...nts/quality-assurance-events.component.ts → ...nts/quality-assurance-events.component.ts b/...nts/quality-assurance-events.component.ts → ...nts/quality-assurance-events.component.ts
@@ -12,10 +12,10 @@ import { RemoteData } from '../../../core/data/remote-data';
 import {
   OpenaireQualityAssuranceEventMessageObject,
   QualityAssuranceEventObject
-} from '../../../core/suggestion-notifications/qa/models/quality-assurance-event.model';
+} from '../../../core/notifications/qa/models/quality-assurance-event.model';
 import {
   QualityAssuranceEventDataService
-} from '../../../core/suggestion-notifications/qa/events/quality-assurance-event-data.service';
+} from '../../../core/notifications/qa/events/quality-assurance-event-data.service';
 import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
 import { Metadata } from '../../../core/shared/metadata.utils';
 import { followLink } from '../../../shared/utils/follow-link-config.model';
@@ -95,6 +95,10 @@ export class QualityAssuranceEventsComponent implements OnInit, OnDestroy {
    * @type {boolean}
    */
   public showMore = false;
+  /**
+   * The Open Aire base url for project search
+   */
+  public openAireUrl = 'https://explore.openaire.eu/search/project?projectId=';
   /**
    * The FindListOptions object
    */

diff --git a/...project-entry-import-modal.component.html → ...project-entry-import-modal.component.html b/...project-entry-import-modal.component.html → ...project-entry-import-modal.component.html
@@ -9,7 +9,7 @@ <h4 class="modal-title" id="modal-title">{{ (labelPrefix + label + '.title') | t
   <small>{{ (labelPrefix + label + '.publication' | translate) }}</small>
   <div class="mb-3">
     <div class="text-truncate">
-      <a target="_blank" href="/items/{{(externalSourceEntry.event.target|async)?.payload?.id}}">
+      <a target="_blank" [routerLink]="'/items/{{(externalSourceEntry.event.target|async)?.payload?.id}}'">
         {{externalSourceEntry.title}}
       </a>
     </div>
@@ -18,7 +18,7 @@ <h4 class="modal-title" id="modal-title">{{ (labelPrefix + label + '.title') | t
     <small>{{ (labelPrefix + label + '.bountToLocal' |translate) }}</small>
     <div class="mb-3">
       <div class="text-truncate">
-        <a target="_blank" href="/items/{{externalSourceEntry.projectId}}">
+        <a target="_blank" [routerLink]="'/items/{{externalSourceEntry.projectId}}'">
           {{externalSourceEntry.projectTitle}}
         </a>
       </div>

diff --git a/...project-entry-import-modal.component.scss → ...project-entry-import-modal.component.scss b/...project-entry-import-modal.component.scss → ...project-entry-import-modal.component.scss
diff --git a/...ject-entry-import-modal.component.spec.ts → ...ject-entry-import-modal.component.spec.ts b/...ject-entry-import-modal.component.spec.ts → ...ject-entry-import-modal.component.spec.ts
diff --git a/...l/project-entry-import-modal.component.ts → ...l/project-entry-import-modal.component.ts b/...l/project-entry-import-modal.component.ts → ...l/project-entry-import-modal.component.ts
@@ -15,7 +15,7 @@ import { DSpaceObject } from '../../../core/shared/dspace-object.model';
 import {
   OpenaireQualityAssuranceEventMessageObject,
   QualityAssuranceEventObject,
-} from '../../../core/suggestion-notifications/qa/models/quality-assurance-event.model';
+} from '../../../core/notifications/qa/models/quality-assurance-event.model';
 import { hasValue, isNotEmpty } from '../../../shared/empty.util';
 import { Item } from '../../../core/shared/item.model';