Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#7 #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Issue#7 #16

wants to merge 6 commits into from

Conversation

azalut
Copy link

@azalut azalut commented Feb 16, 2015

templating idea can be changed if you have any suggestions
for now: every controller should return template.ftl and in the model an attribute "container" containing path to .ftl file should be added; look at the code, my idea quite self explaining

…o be added as container model attribute in every controller that returns template view
@@ -47,7 +48,7 @@
<property name="driverClassName" value="com.mysql.jdbc.Driver" />
<property name="url" value="jdbc:mysql://localhost:3306/test" />
<property name="username" value="root" />
<property name="password" value="pass" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can not change configuration like that, we need to figure it out how to store that localy

@azalut
Copy link
Author

azalut commented Feb 16, 2015

so then should we determine database name, username and password for everyone of us? so everyone would use the same data? btw. forgot to change it back sorry ;)

@gaua
Copy link
Contributor

gaua commented Feb 16, 2015

No, we should not. I'm not familiar with spring yet but there have to be way to store local configuration or parameters.

http://stackoverflow.com/questions/22757318/different-property-variable-for-local-and-prod-environment-spring

They call it profiles.

@azalut
Copy link
Author

azalut commented Feb 16, 2015

the best idea is to create separated task/issue for that :)

Conflicts:
	src/main/java/net/_4programmers/_4note/controllers/UsersController.java
	src/main/webapp/WEB-INF/views/user.ftl
</@layout.block>

<div class="container">
<div class="jumbotron content">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure it is good idea to surround a main content with jumbotron class :)

@azalut
Copy link
Author

azalut commented Feb 17, 2015

yes sure, I will send next commit for a while

@azalut
Copy link
Author

azalut commented Feb 18, 2015

should I merge it to the master?

@gaua
Copy link
Contributor

gaua commented Feb 19, 2015

If it works fine, go ahead. I'm not sure of bootstrap integration, but we can change it in any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants