-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#7 #16
base: master
Are you sure you want to change the base?
Conversation
…e located in: /resources/css
…o be added as container model attribute in every controller that returns template view
@@ -47,7 +48,7 @@ | |||
<property name="driverClassName" value="com.mysql.jdbc.Driver" /> | |||
<property name="url" value="jdbc:mysql://localhost:3306/test" /> | |||
<property name="username" value="root" /> | |||
<property name="password" value="pass" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can not change configuration like that, we need to figure it out how to store that localy
so then should we determine database name, username and password for everyone of us? so everyone would use the same data? btw. forgot to change it back sorry ;) |
No, we should not. I'm not familiar with spring yet but there have to be way to store local configuration or parameters. They call it profiles. |
the best idea is to create separated task/issue for that :) |
Conflicts: src/main/java/net/_4programmers/_4note/controllers/UsersController.java src/main/webapp/WEB-INF/views/user.ftl
</@layout.block> | ||
|
||
<div class="container"> | ||
<div class="jumbotron content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure it is good idea to surround a main content with jumbotron class :)
yes sure, I will send next commit for a while |
should I merge it to the master? |
If it works fine, go ahead. I'm not sure of bootstrap integration, but we can change it in any time. |
templating idea can be changed if you have any suggestions
for now: every controller should return template.ftl and in the model an attribute "container" containing path to .ftl file should be added; look at the code, my idea quite self explaining