-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pending job sync #8104
Open
elioschmutz
wants to merge
5
commits into
es/TI-1494-non-signers-sign-request
Choose a base branch
from
es/TI-1494-pending-job-sync
base: es/TI-1494-non-signers-sign-request
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pending job sync #8104
elioschmutz
wants to merge
5
commits into
es/TI-1494-non-signers-sign-request
from
es/TI-1494-pending-job-sync
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elioschmutz
force-pushed
the
es/TI-1494-non-signers-sign-request
branch
from
December 19, 2024 16:28
55c68bf
to
9191de5
Compare
elioschmutz
force-pushed
the
es/TI-1494-pending-job-sync
branch
2 times, most recently
from
December 19, 2024 16:37
e2c2152
to
b333d36
Compare
elioschmutz
force-pushed
the
es/TI-1494-pending-job-sync
branch
from
December 23, 2024 06:42
b333d36
to
90bf0cd
Compare
buchi
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM
@@ -0,0 +1 @@ | |||
Provides an endpoint to sync pending signing jobs with the external sign service. [elioschmutz] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Provides an endpoint to sync pending signing jobs with the external sign service. [elioschmutz] | |
Provide an endpoint to sync pending signing jobs with the external sign service. [elioschmutz] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
@update-pending-signing-job
endpoint and provides theupdate_url
to thesign
service which will use it to sync editors and signers from skribble to gever.See related
ogsign
-PR: https://github.com/4teamwork/ogsign/pull/13 for the implementation there.The PR adressses the
PATCH /<update_url>
section of this chart:For TI-1494
Checklist
Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.