Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending job sync #8104

Open
wants to merge 5 commits into
base: es/TI-1494-non-signers-sign-request
Choose a base branch
from

Conversation

elioschmutz
Copy link
Member

@elioschmutz elioschmutz commented Dec 19, 2024

This PR introduces the @update-pending-signing-job endpoint and provides the update_url to the sign service which will use it to sync editors and signers from skribble to gever.

See related ogsign-PR: https://github.com/4teamwork/ogsign/pull/13 for the implementation there.

The PR adressses the PATCH /<update_url> section of this chart:

┌───────┐                          ┌────────┐                    ┌───────────┐
│       │ POST /signing-jobs/      │        │                    │           │
│       ├─────────────────────────►│        │                    │           │
│       │                          │        │ POST /convert      │           │
│       │                          │        ├───────────────────►│           │
│       │                          │        │◄-------------------│           │
│       │                          │        │                    │           │
│       │                          │        │                    │ Bumblebee │
│       │                          │        │ POST /bb-callback  │           │
│       │                          │        │◄───────────────────┤           │
│       │                          │        │-------------------►│           │
│       │                          │        │                    │           │
│       │                          │        │                    │           │
│       │                          │        │                    │           │
│       │                          │        │                    └───────────┘
│       │                          │        │
│ GEVER │                          │ ogsign │                    ┌───────────┐
│       │                          │        │(start signing req) │           │
│       │                          │        ├───────────────────►│           │
│       │                          │        │◄-------------------│           │
│       │   {"redirect_url": ...}  │        │                    │           │
│       │◄-------------------------│        │                    │           │
│       │                          │        │                    │  External │
│       │                          │        │       (poll)       │           │
│       │                          │        ├───────────────────►│  Signing  │
│       │                          │        │                    │           │
│       │                          │        │                    │  Provider │
│       │                          │        │                    │           │
│       │ PATCH /<update_url>      │        │   (state changed)  │           │
│       │◄─────────────────────────│        │◄-------------------│           │
│       │                          │        │                    │           │
│       │ POST /<upload_url>       │        │     (signed PDF)   │           │
│       │◄─────────────────────────┤        │◄-------------------│           │
│       │-------------------------►┤        │                    │           │
└───────┘                          └────────┘                    └───────────┘

For TI-1494

Checklist

Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.

  • Changelog entry
  • Link to issue (Jira or GitHub) and backlink in issue (Jira)

@elioschmutz elioschmutz force-pushed the es/TI-1494-non-signers-sign-request branch from 55c68bf to 9191de5 Compare December 19, 2024 16:28
@elioschmutz elioschmutz force-pushed the es/TI-1494-pending-job-sync branch 2 times, most recently from e2c2152 to b333d36 Compare December 19, 2024 16:37
@elioschmutz elioschmutz force-pushed the es/TI-1494-pending-job-sync branch from b333d36 to 90bf0cd Compare December 23, 2024 06:42
@elioschmutz elioschmutz requested a review from a team December 23, 2024 07:03
Copy link
Member

@buchi buchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

@@ -0,0 +1 @@
Provides an endpoint to sync pending signing jobs with the external sign service. [elioschmutz]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Provides an endpoint to sync pending signing jobs with the external sign service. [elioschmutz]
Provide an endpoint to sync pending signing jobs with the external sign service. [elioschmutz]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants