Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Update Shared components packages to v18 (major) #155

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 30, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) 17.0.50 -> 18.0.21 age adoption passing confidence
@types/react-dom (source) 17.0.17 -> 18.0.6 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled due to failing status checks.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Aug 30, 2022

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @testing-library/[email protected]
npm ERR! Found: @types/[email protected]
npm ERR! node_modules/@types/react
npm ERR!   dev @types/react@"18.0.21" from the root project
npm ERR!   @types/react@"*" from @types/[email protected]
npm ERR!   node_modules/@types/react-router
npm ERR!     @types/react-router@"*" from @types/[email protected]
npm ERR!     node_modules/@types/react-router-dom
npm ERR!       dev @types/react-router-dom@"5.3.3" from the root project
npm ERR!   2 more (@types/react-router-dom, @types/react-dom)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @types/react@"^16.9.0 || ^17.0.0" from @testing-library/[email protected]
npm ERR! node_modules/@testing-library/react-hooks
npm ERR!   dev @testing-library/react-hooks@"8.0.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @types/[email protected]
npm ERR! node_modules/@types/react
npm ERR!   peerOptional @types/react@"^16.9.0 || ^17.0.0" from @testing-library/[email protected]
npm ERR!   node_modules/@testing-library/react-hooks
npm ERR!     dev @testing-library/react-hooks@"8.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2022-09-23T07_22_16_443Z-debug-0.log

@renovate renovate bot force-pushed the renovate/major-18-shared-components-packages branch 8 times, most recently from 02121f9 to 4fa599c Compare September 5, 2022 13:51
@renovate renovate bot force-pushed the renovate/major-18-shared-components-packages branch 8 times, most recently from 813d8b9 to c013863 Compare September 12, 2022 15:30
@renovate renovate bot force-pushed the renovate/major-18-shared-components-packages branch 4 times, most recently from 5bbd7d3 to 0a1f793 Compare September 20, 2022 14:03
@jomarko
Copy link

jomarko commented Sep 21, 2022

The very same update is intended on app-services-components-ui

However even there are needed some adjustments to pass CI:

@renovate renovate bot force-pushed the renovate/major-18-shared-components-packages branch from 0a1f793 to f723514 Compare September 21, 2022 15:46
@jomarko
Copy link

jomarko commented Sep 22, 2022

As the same update was rejected in app-services-components-ui I think we can close this PR too. See PRs linked in #155 (comment)

@renovate renovate bot force-pushed the renovate/major-18-shared-components-packages branch 2 times, most recently from 13306d5 to 8b3e3b7 Compare September 22, 2022 19:07
@renovate renovate bot force-pushed the renovate/major-18-shared-components-packages branch from 8b3e3b7 to 5b400c6 Compare September 23, 2022 07:22
@kelvah
Copy link
Collaborator

kelvah commented Sep 23, 2022

@jomarko +1 on closing this

@jomarko
Copy link

jomarko commented Sep 23, 2022

Closing without merge, explanation is in comments above.

@jomarko jomarko closed this Sep 23, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Sep 23, 2022

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 18.x releases. But if you manually upgrade to 18.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/major-18-shared-components-packages branch September 23, 2022 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants