-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Refactor for better maintainability #17
Conversation
31856ad
to
1095ed3
Compare
4d99f7c
to
e0494ca
Compare
4861ce0
to
b337b1f
Compare
cfd4482
to
ada1f37
Compare
ada1f37
to
dcf3bb8
Compare
5956966
to
757e140
Compare
Signed-off-by: Anurag Rajawat <[email protected]>
757e140
to
84931da
Compare
8dacfa4
to
ea6074d
Compare
@daemon1024 Can you review? |
ea6074d
to
9969472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial Review, PTAL
9969472
to
431bb1d
Compare
Signed-off-by: Anurag Rajawat <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
431bb1d
to
bae8efc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits! Rest LGTM 👌🏽
Signed-off-by: Anurag Rajawat <[email protected]>
5b66579
to
d2d9ce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have added the Labels in WASM and Envoy Filter as well, Nice 👌🏽
LGTM 🙌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a comment.
Description
Part of #26
This PR introduces a significant change to the access-log observability implementation:
Replaces istio telemetry with envoy wasm plugin:
Configurable Knobs:
New
APIEvent
Protobuf Message:APIEvent
for structured API call event data.Exposes API Event Collection Endpoints:
Out of the box, SentryFlow exposes two endpoints for receiving API events from external sources:
POST
endpoint at/api/v1/events
on port8081
allows external sources to send API events in the definedAPIEvent
structure.SendAPIEvent
(running on the configured.exporter.grpc.port
) provides another option for sending API events.Does this PR introduce a breaking change?
Yes, this PR introduces a breaking change due to the shift from istio telemetry objects to the Wasm plugin for access log observability.
Additional Information for Reviewers
Docs and test cases will be incorporated after core functionalities are reviewed and approved.
To try it locally
deployments/sentryflow.yaml
manifest file:Execute following from project's root directory:
8080
to get the logs for called APIs:client.tgz