Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Nginx support #22

Merged
merged 3 commits into from
Nov 19, 2024
Merged

feat: Add Nginx support #22

merged 3 commits into from
Nov 19, 2024

Conversation

anurag-rajawat
Copy link
Contributor

@anurag-rajawat anurag-rajawat commented Oct 12, 2024 •
edited
Loading

Description

This PR

  • Adds nginx njs script to observe API calls.
  • Adds support for Nginx Inc ingress controller.
  • Adds support to observe API calls made to an application backed by nginx web server on a VM.

@anurag-rajawat anurag-rajawat marked this pull request as ready for review October 22, 2024 09:30
@anurag-rajawat anurag-rajawat changed the title feat: Add Nginx njs script feat: Add Nginx support Oct 23, 2024
@anurag-rajawat anurag-rajawat added the enhancement New feature or request label Oct 23, 2024
@anurag-rajawat anurag-rajawat self-assigned this Oct 25, 2024
@nandhued nandhued linked an issue Nov 4, 2024 that may be closed by this pull request
North/South Traffic API monitoring #14
Closed
PrimalPimmy
PrimalPimmy reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@PrimalPimmy PrimalPimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

sentryflow/config/default.yaml Show resolved Hide resolved
@PrimalPimmy PrimalPimmy mentioned this pull request Nov 18, 2024
Merged
daemon1024
daemon1024 reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

daemon1024
daemon1024 previously approved these changes Nov 18, 2024
View reviewed changes
@anurag-rajawat anurag-rajawat marked this pull request as draft November 18, 2024 05:58
@anurag-rajawat anurag-rajawat marked this pull request as ready for review November 18, 2024 07:39
PrimalPimmy
PrimalPimmy approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@PrimalPimmy PrimalPimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PrimalPimmy PrimalPimmy merged commit b27c041 into 5GSEC:main Nov 19, 2024
10 checks passed
@anurag-rajawat anurag-rajawat deleted the feat-ngx-njs branch November 19, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrimalPimmy PrimalPimmy PrimalPimmy approved these changes

@daemon1024 daemon1024 daemon1024 left review comments

Assignees

@anurag-rajawat anurag-rajawat

Labels
enhancement New feature or request
Projects
SentryFlow
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

North/South Traffic API monitoring
3 participants
@anurag-rajawat @PrimalPimmy @daemon1024