Fix ignore selection color for QCalendarWidget on Qt5 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 39 39
Lines 1418 1418
=======================================
Hits 1395 1395
Misses 23 23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #207.
Current QTableView item selection color is set with
:selected, not useselection-background-colorproperty.But on Qt5, QCalendarWidget style ignore
pseudo-statesof QTableView::item.I think this is Qt bug.
To fix this bug, I add
selection-background-colorto QCalendarWidget style.But this issue cannot be completely fixed.
Because color behavior is different between
selection-background-colorand:selected.selection-background-colorchanges background color but:selecteddisplays selection color overlaid on background color.