Integration with JS client #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added possibility to render custom attributes on a banner tag - added rendering of data attribute `data-amp-banner-external` - fixed fingerprint resolving (now compatible with JS client) - added and fixed tests
Pull Request Test Coverage Report for Build 7041640122
💛 - Coveralls |
- added rendering mode `client_side`
- added method `RendererBridgeInterface::renderClientSide()` and implementations with templates for `phtml` and `latte` bridges
- added method `RendererInterface::renderClientSide()`
- removed prefix `Template*` from constants in class `Templates`
- added possibility to define alternative rendering modes in `RendererProvider`
- added option `alternative_rendering_modes` in `AmpClientLatteExtension`
- added option `renderer.templates.client_side` in `AmpClientExtension`
- added possibility to switch rendering mode in macro `{banner}` by specifying the argument `mode`
- added and fixed tests
- updated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.