Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed banners support #4

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Embed banners support #4

merged 5 commits into from
Apr 4, 2024

Conversation

tg666
Copy link
Contributor

@tg666 tg666 commented Dec 12, 2023

  • added integration of the new AMP API field mode
  • added possibility to render embed banners
  • added new rendering mode embed (EmbedRenderingMode) for the Latte bridge
  • updated docs
  • updated CHANGELOG
  • fixed and added tests

- added integration of the new AMP API field `mode`
- added possibility to render embed banners
- added new rendering mode `embed` (`EmbedRenderingMode`) for the Latte bridge
- updated docs
- updated CHANGELOG
- fixed and added tests
@tg666 tg666 added the enhancement New feature or request label Dec 12, 2023
@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 8548697359

Details

  • 62 of 63 (98.41%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.953%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Response/Hydrator/BannersResponseHydratorHandler.php 6 7 85.71%
Totals Coverage Status
Change from base Build 7056304601: 0.2%
Covered Lines: 1274
Relevant Lines: 1356

💛 - Coveralls

@tg666 tg666 requested a review from jelen07 December 14, 2023 02:17
tg666 added 2 commits April 4, 2024 03:40
- added integration of the new AMP API field `dimensions`
- fixed and added tests
@tg666 tg666 merged commit dfb2c60 into main Apr 4, 2024
7 checks passed
@tg666 tg666 deleted the feature/iframe branch April 4, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants