Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP options + fetchpriority #6

Merged
merged 3 commits into from
Sep 19, 2024
Merged

AMP options + fetchpriority #6

merged 3 commits into from
Sep 19, 2024

Conversation

tg666
Copy link
Contributor

@tg666 tg666 commented Aug 29, 2024

No description provided.

- added support for new banner option `fetchpriority`
- added support for banner options defined in the AMP administration
- the option `loading` is now processed as an expression. The option `loading-offset` is ignored
- updated docs
@tg666 tg666 requested a review from jelen07 August 29, 2024 04:40
@tg666 tg666 linked an issue Aug 29, 2024 that may be closed by this pull request
3 tasks
@coveralls
Copy link

coveralls commented Aug 29, 2024

Pull Request Test Coverage Report for Build 10944157197

Details

  • 109 of 113 (96.46%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Expression/ExpressionParser.php 37 38 97.37%
src/Http/Cache/CacheControlHeader.php 1 2 50.0%
src/Renderer/Options.php 11 13 84.62%
Totals Coverage Status
Change from base Build 8548709971: 0.2%
Covered Lines: 1371
Relevant Lines: 1456

💛 - Coveralls

@tg666 tg666 merged commit 146e179 into main Sep 19, 2024
7 checks passed
@tg666 tg666 deleted the feature/amp-options branch September 19, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync with JS client
2 participants