Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added integration of the new fields close_expiration #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added integration of the new fields close_expiration #8

wants to merge 1 commit into from

Conversation

tg666
Copy link
Contributor

@tg666 tg666 commented Oct 17, 2024

No description provided.

@tg666
Added integration of the new fields close_expiration into Position …
f005c33 
…and Banner entities and also into the `data-amp-banner-external` and `data-amp-banner-fingerprint` attributes
@tg666 tg666 self-assigned this Oct 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11376363211

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 94.186%
Totals Coverage Status
Change from base Build 11284199590: 0.03%
Covered Lines: 1377
Relevant Lines: 1462
💛 - Coveralls

@tg666 tg666 requested a review from jelen07 October 17, 2024 02:47
jelen07
jelen07 approved these changes Oct 17, 2024
View reviewed changes
Copy link

@jelen07 jelen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelen07 jelen07 jelen07 approved these changes

Assignees

@tg666 tg666

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tg666 @coveralls @jelen07