V8.4.3 fixes #285

781flyingdutchman · Apr 12, 2024 · ec82234 · ec82234
1 parent d6dd545
commit ec82234
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/example/integration_test/downloader_integration_test.dart b/example/integration_test/downloader_integration_test.dart
@@ -2396,6 +2396,7 @@ void main() {
         lastProgress = -1; // must change to a real value
         await downloader
             .retrieveLocallyStoredData(); // triggers status & prog update
+        downloader.retrievedLocallyStoredData = false; // reset for testing
         await Future.delayed(const Duration(milliseconds: 500));
         expect(lastStatus, equals(TaskStatus.paused));
         expect(lastProgress, equals(oldLastProgress));
@@ -2445,6 +2446,7 @@ void main() {
             taskStatusCallback: (update) => taskStatusUpdate = update);
         await Future.delayed(const Duration(milliseconds: 500));
         await downloader.retrieveLocallyStoredData(); // triggers status update
+        downloader.retrievedLocallyStoredData = false; // reset for testing
         await Future.delayed(const Duration(milliseconds: 500));
         expect(taskStatusUpdate.status, equals(TaskStatus.complete));
         expect(taskStatusUpdate.exception, isNull);
@@ -2481,6 +2483,7 @@ void main() {
             taskStatusCallback: (update) => taskStatusUpdate = update);
         await Future.delayed(const Duration(milliseconds: 500));
         await downloader.retrieveLocallyStoredData(); // triggers status update
+        downloader.retrievedLocallyStoredData = false; // reset for testing
         await Future.delayed(const Duration(milliseconds: 500));
         expect(taskStatusUpdate.status, equals(TaskStatus.failed));
         exception = taskStatusUpdate.exception as TaskHttpException;

diff --git a/lib/src/base_downloader.dart b/lib/src/base_downloader.dart
@@ -94,7 +94,8 @@ abstract base class BaseDownloader {
   final canResumeTask = <Task, Completer<bool>>{};
 
   /// Flag indicating we have retrieved missed data
-  var _retrievedLocallyStoredData = false;
+  @visibleForTesting
+  var retrievedLocallyStoredData = false;
 
   /// Connected TaskQueues that will receive a signal upon task completion
   final taskQueues = <TaskQueue>[];
@@ -180,7 +181,7 @@ abstract base class BaseDownloader {
   /// Retrieve data that was stored locally because it could not be
   /// delivered to the downloader
   Future<void> retrieveLocallyStoredData() async {
-    if (!_retrievedLocallyStoredData) {
+    if (!retrievedLocallyStoredData) {
       final resumeDataMap = await popUndeliveredData(Undelivered.resumeData);
       for (var jsonString in resumeDataMap.values) {
         final resumeData = ResumeData.fromJsonString(jsonString);
@@ -197,7 +198,7 @@ abstract base class BaseDownloader {
       for (var jsonString in progressUpdateMap.values) {
         processProgressUpdate(TaskProgressUpdate.fromJsonString(jsonString));
       }
-      _retrievedLocallyStoredData = true;
+      retrievedLocallyStoredData = true;
     }
   }