clarify --verify help text #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer the user to --manual instead of --help, since that's where the detailed instructions for --verify can be found.
|
Thank you @barathrm for this fix. Sorry for my late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer the user to --manual instead of --help, since that's where the detailed instructions for --verify can be found.
I first thought I had the same issue as #93 until I discovered that verification will only work if the non-matrix-commander client explicitly requests an emoji verification. The "regular" button in element (under "Settings/Security/Where you're signed in") only says "verify" and doesn't work, one needs to go via a room list to find this button. I guess this also means I can't verify matrix-commander from for instance nheko, which doesn't have an explicit button for emoji verification (I think).
I only discovered the extra help text by checking the verify code in matrix-commander, so I hope changing this to from --help to --manual will point people in the right direction at least.