Adding touch ID support (via new data protection keychain) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexw23
changed the title
SecItemUpdate only accepts the SetData (kSecValueData) param for an update when SetAccessControl (kSecAttrAccessControl) was set on original item.
Also added a check to ensure we are running in a bundled app context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update mainly enables Touch ID support and adds support for data protection keychain.
From this article, macOS has two keychain implementations:
Currently this package is using the (File-based keychain). However eventually, the file-based keychain will be phased out and is unofficially deprecated by Apple.
The new keychain (
data_protection_keychain.go) is mostly copied fromkeychain.go. There were some challenges because keychain.go currently relies on99-designs/go-keychainwhich is quite an old version, and the latest version ofkeybase/go-keychainhas removed support for file-based keychain.Merging
keybase/go-keychainback into 99designs/go-keychain doesn't make sense askeybaseis more actively maintained. I've locked to my current PR of keychain/go-keychain.The existing keychain.go can still be used but should be considered as
FileBasedKeychain. I didn't rename it for compatibility reasons.Testing hasn't been added yet because end-to-end testing the data protection keychain requires a signed macOS app, so we need to figure out how to do that on a CI/CD level.