Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 방문한 기업 조회 위도, 경도 추가 #24

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

haeun1107
Copy link
Collaborator

@haeun1107 haeun1107 commented Nov 19, 2024

Related Issue 🍀


Key Changes 🔑

  • 방문한 기업 조회 위도, 경도 추가

To Reviewers 🙏🏻

Summary by CodeRabbit

  • New Features

    • Added geographical coordinates (latitude and longitude) to the visited enterprise response.
  • Bug Fixes

    • Removed the title field from review creation and response, streamlining the review process.

These updates enhance the information provided to users regarding enterprises while simplifying the review submission process.

@haeun1107 haeun1107 self-assigned this Nov 19, 2024
Copy link

coderabbitai bot commented Nov 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the VisitConverter, VisitDTO, ReviewConverter, and ReviewDTO classes. The VisitConverter now includes latitude and longitude in the GetVisitedEnterpriseResponse, while the ReviewConverter and ReviewDTO have removed the title field from review-related responses. These updates enhance the geographical information provided for enterprises and streamline the review structure by omitting the title from both the creation and response processes.

Changes

File Path Change Summary
src/main/java/danpoong/soenter/domain/enterprise/dto/VisitConverter.java Enhanced toVisitedEnterpriseResponse method to include latitude and longitude fields.
src/main/java/danpoong/soenter/domain/enterprise/dto/VisitDTO.java Added latitude and longitude fields to GetVisitedEnterpriseResponse static class.
src/main/java/danpoong/soenter/domain/review/converter/ReviewConverter.java Removed title field from toReview and toReviewResponse methods, altering review structure.
src/main/java/danpoong/soenter/domain/review/dto/ReviewDTO.java Removed title field from PostReviewResponse static class.

Possibly related issues

🐰 In fields of green, I hop and play,
With coordinates to guide the way.
Reviews now simpler, titles set free,
A world of data, come dance with me!
🌍✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@haeun1107 haeun1107 merged commit 157b464 into main Nov 19, 2024
1 of 2 checks passed
@haeun1107 haeun1107 deleted the refactor/#21 branch November 20, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant