Merge pull request #17 from A2-ai/report_logo_render_bug

Report logo render bug
A2-ai · Nov 1, 2024 · a8ed9c3 · a8ed9c3
2 parents eefef7d + 8e3369d
commit a8ed9c3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: ghqc.app
 Title: Create QC Checklists in Github Issues
-Version: 0.1.6
+Version: 0.1.7
 Authors@R: c(
     person("Jenna", "Johnson", email = "[email protected]", role = c("aut", "cre")),
     person("Anne", "Zheng", email = "[email protected]", role = c("aut")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# ghqc.app 0.1.7
+
+- Fixes bug in rendered reports in which a maximum height for logos wasn't set to prevent overlapping header lines and header text.
+
 # ghqc.app 0.1.6
 
 - Fixes bug in record app for previewing markdown files (same bug and solution as in 0.1.4)

diff --git a/R/scrape.R b/R/scrape.R
@@ -375,15 +375,15 @@ create_intro <- function(repo, milestone_names) {
   - \\newcolumntype{{R}}[1]{{>{{\\raggedright\\arraybackslash}}p{{#1}}}}
   - \\newcommand{{\\blandscape}}{{\\begin{{landscape}}}}
   - \\newcommand{{\\elandscape}}{{\\end{{landscape}}}}
-  - \\fancyhead[R]{{\\includegraphics[width=2cm]{{{image_path}}}}}
+  - \\fancyhead[R]{{\\includegraphics[width=2cm, height=1.5cm, keepaspectratio]{{{image_path}}}}}
   - \\fancyhead[C]{{}}
   - \\fancyhead[L]{{}}
   - \\setlength{{\\headheight}}{{30pt}}
   - \\fancyfoot[C]{{Page \\thepage\\ of \\pageref{{LastPage}}}}
   - \\usepackage{{lastpage}}
   - \\lstset{{breaklines=true}}
   - \"\\\\fancypagestyle{{plain}}{{\"
-  - \"\\\\fancyhead[R]{{\\\\includegraphics[width=2cm]{{{image_path}}}}}\"
+  - \"\\\\fancyhead[R]{{\\\\includegraphics[width=2cm, height=1.5cm, keepaspectratio]{{{image_path}}}}}\"
   - \"\\\\renewcommand{{\\\\headrulewidth}}{{0.4pt}}\"
   - \"}}\"
   output: