Skip to content

Commit

Permalink
Merge pull request #3 from A2-ai/env_url_bug
Browse files Browse the repository at this point in the history
env_url not being returned from get_env_url
  • Loading branch information
jenna-a2ai authored Oct 29, 2024
2 parents 4ec852a + 8e22bc5 commit ab92c09
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: ghqc.app
Title: Create QC Checklists in Github Issues
Version: 0.1.0
Version: 0.1.1
Authors@R: c(
person("Jenna", "Johnson", email = "[email protected]", role = c("aut", "cre")),
person("Anne", "Zheng", email = "[email protected]", role = c("aut")),
Expand Down
12 changes: 12 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@

# ghqc.app (beta version)

# ghqc.app 0.1.1

# Minor bug fixes

- In the case when someone sets the standard gh environment variable GITHUB_API_URL, each app checks if this URL matches the actual set remote URL. The function that gets the GITHUB_API_URL did not explicitly return a value.

- Small grammar fix in error message from apps in the case that the checklists directory isn't in the cloned info repo.


# ghqc.app (development version)

# ghqc.app 0.0.0.9011
Expand Down
1 change: 1 addition & 0 deletions R/auth_git.R
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ get_env_url <- function() {
env_url <- gsub("/$", "", env_url)
env_url <- stringr::str_remove(env_url, "/api/v3$")
if (!stringr::str_starts(env_url, "https://")) env_url <- paste0("https://", env_url)
env_url
}

#' @importFrom log4r warn error info debug
Expand Down

0 comments on commit ab92c09

Please sign in to comment.