Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading language #12

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Misleading language #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a19da
changes No Existing Milestones to No Open Milestones
jenna-a2ai Oct 31, 2024
3259eb2
updates version to 0.1.3 and adds to NEWS.md
jenna-a2ai Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: ghqc.app
Title: Create QC Checklists in Github Issues
Version: 0.1.2
Version: 0.1.3
Authors@R: c(
person("Jenna", "Johnson", email = "[email protected]", role = c("aut", "cre")),
person("Anne", "Zheng", email = "[email protected]", role = c("aut")),
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@

# ghqc.app (beta version)

# ghqc.app 0.1.3

- Changes "No Existing Milestones"" to "No Open Milestones" in ghqc_assign_app() Existing Milestones dropdown menu

# ghqc.app 0.1.2

- Fixes bug in record app warning modal pop-up for unclosed milestones/issues/checklist items: Milestone link wasn't clickable
Expand Down
2 changes: 1 addition & 1 deletion R/app_01_assign_server.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ghqc_assign_server <- function(id, remote, root_dir, checklists, org, repo, memb
updateSelectizeInput(
session,
"milestone_existing",
options = list(placeholder = "No Existing Milestones")
options = list(placeholder = "No Open Milestones")
)
}

Expand Down
Loading