Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env_url not being returned from get_env_url #3

Merged
merged 2 commits into from
Oct 29, 2024
Merged

env_url not being returned from get_env_url #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df5dad0
env_url not being returned from get_env_url
jenna-a2ai Oct 29, 2024
8e22bc5
adds to NEWS.md and ups version to 0.1.1
jenna-a2ai Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: ghqc.app
Title: Create QC Checklists in Github Issues
Version: 0.1.0
Version: 0.1.1
Authors@R: c(
person("Jenna", "Johnson", email = "[email protected]", role = c("aut", "cre")),
person("Anne", "Zheng", email = "[email protected]", role = c("aut")),
Expand Down
12 changes: 12 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@

# ghqc.app (beta version)

# ghqc.app 0.1.1

# Minor bug fixes

- In the case when someone sets the standard gh environment variable GITHUB_API_URL, each app checks if this URL matches the actual set remote URL. The function that gets the GITHUB_API_URL did not explicitly return a value.

- Small grammar fix in error message from apps in the case that the checklists directory isn't in the cloned info repo.


# ghqc.app (development version)

# ghqc.app 0.0.0.9011
Expand Down
1 change: 1 addition & 0 deletions R/auth_git.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ get_env_url <- function() {
env_url <- gsub("/$", "", env_url)
env_url <- stringr::str_remove(env_url, "/api/v3$")
if (!stringr::str_starts(env_url, "https://")) env_url <- paste0("https://", env_url)
env_url
}

#' @importFrom log4r warn error info debug
Expand Down
Loading