Fixed stderr messaging. only shows if non empty for footnote addition

A2-ai · Oct 31, 2024 · 0cfa6e3 · 0cfa6e3
1 parent 7e5e0d8
commit 0cfa6e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/R/add_footnotes.R b/R/add_footnotes.R
@@ -133,7 +133,7 @@ add_footnotes <- function(docx_in,
     result <- processx::run(
       command = uv_path, args = fig_args, env = c("current", VIRTUAL_ENV = venv_path), error_on_status = TRUE
       )
-    if (length(result$stderr) != 0) {
+    if (nzchar(result$stderr)) {
       log4r::warn(.le$logger, paste0("Figure footnotes script stderr: ", result$stderr))
     }
   }, error = function(e) {
@@ -152,7 +152,7 @@ add_footnotes <- function(docx_in,
     result <- processx::run(
       command = uv_path, args = tab_args, env = c("current", VIRTUAL_ENV = venv_path), error_on_status = TRUE
     )
-    if (length(result$stderr) != 0) {
+    if (nzchar(result$stderr)) {
       log4r::warn(.le$logger, paste0("Table footnotes script stderr: ", result$stderr))
     }
   }, error = function(e) {

diff --git a/R/build_report.R b/R/build_report.R
@@ -103,7 +103,7 @@ build_report <- function(docx_in,
         )
       })
     }, error = function(e) {
-      log4r::error(.le$logger, paste("Figure footnotes script failed:", e$message))
+      log4r::error(.le$logger, paste("Footnotes scripts failed:", e$message))
       stop("build_report stopped: Failed to add footnotes due to an error in add_footnotes.", call. = FALSE)
     })
   }