if the {rpfy}: string is in a separate paragraph from the figure, it … #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was not being removed. Updated remove_figure to search the paragraph with {rpfy}: remove the drawing if it's there, if not go to the next paragraph and remove it there if it exists. Additionally, table1_format argument was not being passed from save_rds_with_metadata/write_csv_with_metadata to write_object_metadata.
jacobdum
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…was not being removed. Updated remove_figure to search the paragraph with {rpfy}: remove the drawing if it's there, if not go to the next paragraph and remove it there if it exists. Additionally, table1_format argument was not being passed from save_rds_with_metadata/write_csv_with_metadata to write_object_metadata.
v0.2.3: Table1 formatting was not applied
v0.2.4: Table1 formatting is correctly applied
The following figure would not be removed due to {rpfy}: string being in different paragraph.
The update successfully removes this figure.