Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meta tags to improve SEO #82

Draft
wants to merge 7 commits into
base: staging
Choose a base branch
from
Draft

Add Meta tags to improve SEO #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2cf8419
style: eslint
Nomalah Aug 1, 2023
74c2f97
feat: initial SEO and meta tags for books
Nomalah Aug 1, 2023
bc5864a
feat: run seo generation on pr build
Nomalah Aug 1, 2023
74a3840
feat: more SEO, slightly faster?
Nomalah Aug 1, 2023
4026f70
fix: folders for html
Nomalah Aug 1, 2023
b002b42
feat: initial seo image generation
Nomalah Aug 2, 2023
59bfad4
feat: image generation for all songs
Nomalah Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@ jobs:
run: |
cd build
export VITE_BASE_URL="/${{ env.PR_REPO_NAME }}/"
export SEO_URL="https://acc-hymns.github.io"
export VITE_GIT_BRANCH="$GITHUB_HEAD_REF"
npm i
npm run deploy-check
npm run build
npx cap copy web
node ./seo/seo-deployment.mjs
cd ..

- name: Checkout Dev Target
Expand Down
4 changes: 0 additions & 4 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover">
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>ACC Hymns</title>
<meta property="og:title" content="ACCHymns" />
<meta property="og:description" content="A Collection of ACC Hymnals" />
<meta property="og:url" content="https://acchymns.app/index.html" />
<meta property="og:image" content="https://acchymns.app/assets/icons/180x180.png" />
</head>
<body>
<div id="app"></div>
Expand Down
Loading