Fix use-after free in removeSingleItemFromMenu() #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Instructions
Tested with the graphics test mode currently in the
3d-rendering-apibranch, but it's pretty easy to stick it in the main menu or something and see if it crashes.Ticket Links
Readiness Checklist
make formatto format the changesmake cppcheckand checked thatcppcheck_result.txthas no warnings for the changes/*! \filecomments with Design Philosophy, Usage, and Example sections for new headers.make docsand checked thatdoxy_warnings.txthas no warnings for the new code