Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#73 Add make target to gen c_cpp_properties.json #111

Closed
wants to merge 1 commit into from

Conversation

AEFeinstein
Copy link
Owner

Description

Added make gen-vs-properties to generate .vscode\c_cpp_properties.json

Test Instructions

Deleted .vscode\c_cpp_properties.json, ran make gen-vs-properties, and validated the output.

Ticket Links

#73

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@AEFeinstein AEFeinstein requested a review from Brycey92 November 2, 2023 04:26
@echo " \"${IDF_PATH}/components/**\"" >> $(PROPERTIES_FILE)
@echo " ]," >> $(PROPERTIES_FILE)
@echo " \"defines\": []," >> $(PROPERTIES_FILE)
@echo " \"compilerPath\": \"$(shell which xtensa-esp32s2-elf-gcc)\"," >> $(PROPERTIES_FILE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output is still doing some oddities with UNIX-style paths on Windows:

{
    "configurations": [
        {
            "name": "esp32s2",
            "includePath": [
                "${workspaceFolder}/main/**",
                "${workspaceFolder}/components/**",
                "C:\Users\Bryce\esp\esp-idf/components/**"
            ],
            "defines": [],
            "compilerPath": "/c/Users/Bryce/.espressif/tools/xtensa-esp32s2-elf/esp-12.2.0_20230208/xtensa-esp32s2-elf/bin/xtensa-esp32s2-elf-gcc",
            "compileCommands": "${workspaceFolder}/build/compile_commands.json",
            "cStandard": "c17",
            "cppStandard": "c++17",
            "intelliSenseMode": "gcc-x86"
        }
    ],
    "version": 4
}

Do we have the ability to replace this call with something that puts out Windows paths?

@AEFeinstein
Copy link
Owner Author

AEFeinstein commented Nov 2, 2023 via email

@AEFeinstein AEFeinstein deleted the gen-settings branch November 21, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants