Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick settings polish/bugfixes #116

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Quick settings polish/bugfixes #116

merged 4 commits into from
Nov 8, 2023

Conversation

dylwhich
Copy link
Collaborator

@dylwhich dylwhich commented Nov 8, 2023

Description

  • Add saving and restoring LED state on open/close
  • Fix buzzer not actually playing anything when changing volumes
  • Fix buzzer not resuming after it was both stopped and paused

Test Instructions

Opened and messed with the quick settings menu a bunch in various modes that used BGM/SFX/LEDs.

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@dylwhich dylwhich requested a review from AEFeinstein November 8, 2023 00:38
@AEFeinstein AEFeinstein merged commit f82facd into main Nov 8, 2023
1 check passed
@AEFeinstein AEFeinstein deleted the quick-settings-polish branch November 8, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants