Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting option to use the swadge rotated 180 degrees #127

Closed
wants to merge 1 commit into from

Conversation

dylwhich
Copy link
Collaborator

Description

Adds a "Reverse Thrust!" option in the menu which lets you use the swadge rotated 180 degrees! Not sure if this is something we want, but it turned out to be easier than I thought, so why not?

Test Instructions

Test on hardware. Make sure that the buttons, screen, touchpad, and accelerometer all follow the rotation in a logical way.

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@dylwhich dylwhich requested a review from AEFeinstein November 18, 2023 22:08
@AEFeinstein
Copy link
Owner

Not sure if this is something we want

I don't think anyone asked for it, so I'm gonna leave this one as an unmerged branch (but also not delete it). It's an interesting concept to revisit at some point, and a 90 degree rotation would be interesting for games that want to be in portrait mode...

@dylwhich
Copy link
Collaborator Author

Fair enough! At some point I was just thinking about the debate about holding orientation, and realized that "up" is just like, convention, man. Other than the silkscreen...

@dylwhich dylwhich deleted the flip-swadge branch July 1, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants