Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Techno Slide Whistle Mode #131

Merged
merged 8 commits into from
Nov 19, 2023
Merged

Added Techno Slide Whistle Mode #131

merged 8 commits into from
Nov 19, 2023

Conversation

jt-moriarty
Copy link
Collaborator

Description

Test Instructions

From Main Menu, select "Music"->"Techno SlideWhistle" to enter this mode. From there follow on-screen controls to test various features of the slide whistle.

Ticket Links

None.

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@jt-moriarty jt-moriarty added the utility This is a utility being written for Swadge label Nov 19, 2023
@jt-moriarty jt-moriarty self-assigned this Nov 19, 2023
@jt-moriarty jt-moriarty changed the title Draft until Accelerometer controls are fixed: Added Techno Slide Whistle Mode Added Techno Slide Whistle Mode Nov 19, 2023
@jt-moriarty jt-moriarty marked this pull request as ready for review November 19, 2023 05:09
@AEFeinstein
Limit slide whistle framerate
736e91e 
Update LEDs from main loop, not timer
@AEFeinstein
Don't call bzrPlayNote() if the note doesn't change
0d3a9d2 
Fix volume in slide whistle
AEFeinstein
AEFeinstein approved these changes Nov 19, 2023
View reviewed changes
Copy link
Owner

@AEFeinstein AEFeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some actual hardware bugs where the LEDs were wacky in quick settings and volume was inaccurate. All good now!

@AEFeinstein AEFeinstein merged commit 4081a0d into main Nov 19, 2023
1 check passed
@AEFeinstein AEFeinstein deleted the instrument branch November 19, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AEFeinstein AEFeinstein AEFeinstein approved these changes

Assignees

@jt-moriarty jt-moriarty

Labels
utility This is a utility being written for Swadge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jt-moriarty @AEFeinstein