Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ninth led #80

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Ninth led #80

merged 4 commits into from
Sep 25, 2023

Conversation

AEFeinstein
Copy link
Owner

@AEFeinstein AEFeinstein commented Sep 23, 2023 •
edited
Loading

Description

Automatic 9th LED lighting

Test Instructions

Run LED patterns on actual hardware, validate 9th LED looks sane

Ticket Links

n/a

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@AEFeinstein AEFeinstein marked this pull request as ready for review September 24, 2023 00:38
@AEFeinstein AEFeinstein merged commit 6fc5353 into main Sep 25, 2023
1 check passed
@AEFeinstein AEFeinstein deleted the ninth-led branch September 25, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylwhich dylwhich dylwhich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AEFeinstein @dylwhich