Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port factorytest #88

Merged
merged 14 commits into from
Oct 13, 2023
Merged

Port factorytest #88

merged 14 commits into from
Oct 13, 2023

Conversation

Brycey92
Copy link
Collaborator

Description

Ported factory test mode, modified it for new buzzers and touchpad.

Test Instructions

Tested on emulator and firmware

  • with fresh NVS: mode entered OK
  • after a fail-and-reset: mode entered OK
  • after a pass-and-reset: mode exited OK, not entered again OK
  • after a menu-opened fail-and-reset: mode not entered again OK
  • after a menu-opened pass-and-reset: mode not entered again OK

If any of these behaviors are incorrect, I can change them.

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@Brycey92 Brycey92 requested a review from AEFeinstein October 12, 2023 07:40
Copy link
Owner

@AEFeinstein AEFeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function in header needs to be resolved. I'll try to do that, shouldn't be too bad.

assets/test/kid1.png Outdated Show resolved Hide resolved
main/CMakeLists.txt Outdated Show resolved Hide resolved
* @brief Read, save, and validate accelerometer data
*
*/
void testReadAndValidateAccelerometer(void)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnlohr after this gets merged to main and you want to add your motion and calibration stuff, this is likely the right place to do it

main/modes/factoryTest/factoryTest.c Show resolved Hide resolved
main/modes/mainMenu/mainMenu.c Show resolved Hide resolved
main/modes/touchTest/touchTest.h Outdated Show resolved Hide resolved
@AEFeinstein AEFeinstein merged commit e2a361a into main Oct 13, 2023
1 check passed
@AEFeinstein AEFeinstein deleted the port-factorytest branch October 13, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants