Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced NVS functions #93

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Namespaced NVS functions #93

merged 3 commits into from
Oct 13, 2023

Conversation

dylwhich
Copy link
Collaborator

@dylwhich dylwhich commented Oct 13, 2023

Description

Adds just the additional namespaced NVS functions as well as their emulator counterparts. This PR doesn't change the usage of the existing NVS functions, which should continue to work identically.

Test Instructions

I've only really tested the blob and entry info functions within paint on the emulator. Assuming further testing will be done as a result of moving modes to use the functions.

Ticket Links

#52

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

* @param key The NVS key to be deleted
* @return true if the value was deleted, false if it was not
*/
bool eraseNamespaceNvsKey(const char* namespace, const char* key)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to erase an entire namespace?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like not yet, but could be neat if someone wants it (I don't).

@AEFeinstein AEFeinstein merged commit e125141 into main Oct 13, 2023
1 check passed
@AEFeinstein AEFeinstein deleted the namespaced-nvs branch October 13, 2023 21:17
@AEFeinstein AEFeinstein mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants