ci: Adds a Pull Request template #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As [suggested](#996 (comment)) by @SylviaWhittle we could all do with an _aide memoire_ when making Pull Requests that we have covered everything we should. This Pull Request therefore introduces just such a template to aid contributors in making sure we have covered everything. --- - [ ] Existing tests pass. **N/A** no changes to code base introduced. - [ ] Documentation has been updated and builds. **N/A** no changes to code base introduced. - [x] Pre-commit checks pass. - [ ] New functions/methods have typehints and docstrings. **N/A** no changes to code base introduced. - [ ] New functions/methods have tests which check the intended behaviour is correct. **N/A** no changes to code base introduced.
ns-rse
requested review from
SylviaWhittle,
MaxGamill-Sheffield and
llwiggins
SylviaWhittle
approved these changes
Nov 15, 2024
Co-authored-by: Sylvia Whittle <[email protected]>
ns-rse
force-pushed
the
ns-rse/pull-request-template
branch
from
d0f31b8 to
3a86a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @SylviaWhittle we could all do with an aide memoire when making Pull Requests that we have covered everything we should.
This Pull Request therefore introduces just such a template to aid contributors in making sure we have covered everything.