ci: Adds pygrep-hooks and fixes errors #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1005 As per [PC170](https://learn.scientific-python.org/development/guides/style#PC170): Uses PyGrep hooks (only needed if rST present) adds [pygrep-hooks](https://github.com/pre-commit/pygrep-hooks) to `.pre-commit-config.yaml`. Opted to enable more than just the `rst-` hooks. **NB** This is a stacked commit and should be merged after #1013 from which it was branched.
ns-rse
requested review from
SylviaWhittle,
MaxGamill-Sheffield and
llwiggins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1005
As per PC170: Uses PyGrep hooks (only needed if
rST present) adds pygrep-hooks to
.pre-commit-config.yaml.Opted to enable more than just the
rst-hooks.NB This is a stacked commit and should be merged after #1013 from which it was branched.
Before submitting a Pull Request please check the following.
Existing tests pass.Documentation has been updated and builds. Remember to updateconfiguration.md,usage.md, and relevant processing sections underadvanced.md.New functions/methods have typehints and docstrings.New functions/methods have tests which check the intended behaviour is correct.Optional
topostats/default_config.yamlN/A