Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables legacy unets to run #1042

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

MaxGamill-Sheffield
Copy link
Collaborator

@MaxGamill-Sheffield MaxGamill-Sheffield commented Dec 10, 2024

Closes #1041

Imports the iou_loss and adds compile=False for non-serialised model objects

Builds on maxgamill-sheffield/unet-crop-fix branch (see #1030) so do this after that

@MaxGamill-Sheffield MaxGamill-Sheffield changed the title Rm single crop expansion (l/r) for always both (l+r) Emables legacy unets to run Dec 10, 2024
@MaxGamill-Sheffield MaxGamill-Sheffield changed the title Emables legacy unets to run Enables legacy unets to run Dec 10, 2024
@ns-rse
Copy link
Collaborator

ns-rse commented Dec 10, 2024

Builds on maxgamill-sheffield/unet-crop-fix branch so do this after that

The need to re-add a missing import of mean_iou might be because this branch didn't fork from maxgamill-sheffield/unet-fix-crop rather it forked from main commit 85d65c3 if I've understood the graph history correctly.

But having checked I can't see the mean_iou function being imported on the maxgamill-sheffield/unet-fix-crop branch either so unsure.

If it were meant to build on that earlier branch you should have branched from it and not main (this would have allowed Stacked Pull Requests).

topostats/unet_masking.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post Code clean, all good to go 👍

@MaxGamill-Sheffield MaxGamill-Sheffield added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 7babfca Dec 11, 2024
11 checks passed
@MaxGamill-Sheffield MaxGamill-Sheffield deleted the maxgamill-sheffield/enable-legacy-ts-unets branch December 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Older TopoStats U-Net Models Throw Error on Import
2 participants