tests(unet_masking): Correct ids and add expected fail #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrects the `id` of the parameterised tests for `test_make_bounding_box_square()` to reflect the `row`/`col` and whether they `increase`/`decrease`. - Adds a rectangular image with a large rectangular `bbox` that can not be squared and marks the test as a fail. I recall, but can't find, that we added functionality to handle non-square scans (I think @SylviaWhittle wrote the code to handle it) and so its possible that instances may arise where the `bbox` can't be squared. Ideally we should add a `try: ... except:` to handle such cases but for now adding a test which is marked as expected to fail should serve as an _aide memoire_ that sometimes things won't work.
MaxGamill-Sheffield
merged commit 0625a55
into
maxgamill-sheffield/unet-crop-fix
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idof the parameterised tests fortest_make_bounding_box_square()to reflect therow/coland whether they
increase/decrease.bboxthat can not be squared and marks the test as a fail.I recall, but can't find, that we added functionality to handle non-square scans (I think @SylviaWhittle wrote the code
to handle it) and so its possible that instances may arise where the
bboxcan't be squared.Ideally we should add a
try: ... except:to handle such cases but for now adding a test which is marked as expected tofail should serve as an aide memoire that sometimes things won't work.